1122255 - Add language pack model in zamboni

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Andy McKay]

Create a model in zamboni that contains database tables and constants etc. First job is to figure out what those fields are maybe:

- firefox os version
- language
- created
- updated
- active

We'll also need a version table that is maybe:

- lang pack version number
- path on the file system
- updated
- created
- active

It was suggested that this should be a separate set of models from Webapp, Version and File.

Comment 1

[Mathieu Pillard [:mat]]

Are we really going to need the version table ? It seems overkill...

Comment 2

[Andrew Williamson [:eviljeff]]

could a collection for each FxOS version and a consistent naming scheme achieve this without a new model?

Comment 3

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #2)
> could a collection for each FxOS version and a consistent naming scheme
> achieve this without a new model?

If you're suggesting to wedge language packs into the Webapp model (because collections are collections of apps, right?), I was hoping we could avoid that. Language packs seem different in subtle ways that I fear we'd be fighting an uphill battle adding exceptions all over our code. There's also a future possibility of associating language packs to apps where a separate model would be the right way to model that relationship.

Comment 4

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #3)
> (In reply to Andrew Williamson [:eviljeff] from comment #2)
> > could a collection for each FxOS version and a consistent naming scheme
> > achieve this without a new model?
> 
> If you're suggesting to wedge language packs into the Webapp model (because
> collections are collections of apps, right?), I was hoping we could avoid
> that. Language packs seem different in subtle ways that I fear we'd be
> fighting an uphill battle adding exceptions all over our code. There's also
> a future possibility of associating language packs to apps where a separate
> model would be the right way to model that relationship.

I meant more as an alternative to a osversion table, following on from #c1. So each lang+osversion would be a 'langpack' object, i.e. langpack->version->file like we have with webapps; rather than langpack->osversion->version->file. And if we could use collections to collect all langpacks for a particular osversion if that was needed.

As for langpacks being wedged into Webapp vs a new model, I don't really have a strong on opinion on that. Either way I can see changes being needed in various places.

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/6c71afc5be6f43b0b53e6893f3b45b1a26b91528