1122365 - [Bluetooth][Settings] According to Bluetooth class of device to implement icon style.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail], [e-mail]]

Since Bluetooth API v2 changed, the icon style of Bluetooth device is needed to mapping from Bluetooth class of device(COD).

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] ian-liu:bluetooth/bug1122365_display_icon_via_class_of_device to mozilla-b2g:master

Comment 2

[[e-mail], [e-mail]]

Attachment: pull request 27897

Arthur and Jamin, the patch is relative with the device type/icon. And we use class of device to make a decision for the device type. I reference following doc. to write done the rule. It's meaningful to make our type/icon more readable while a user see these devices in list. So I would like both of your feedback here. Thanks:)

Comment 3

[[e-mail], [e-mail]]

Reference:

* Bluetooth API v1, BluetoothDevice icon property:
  https://developer.mozilla.org/en-US/docs/Web/API/BluetoothDevice.icon
* Bluetooth API v2, BluetoothClassOfDevice object:
  https://wiki.mozilla.org/B2G/Bluetooth/WebBluetooth-v2/
* Bluetooth Class of Device Reference:
  https://www.bluetooth.org/en-us/specification/assigned-numbers/baseband
* Android source code:
  http://code.metager.de/source/xref/android/4.0.4/external/bluetooth/bluez/src/dbus-common.c#192
* Bluetooth Baseband: The General- and Device-Specific Inquiry Access Codes (DIACs)
  http://www.ampedrftech.com/guides/cod_definition.pdf

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8558909 [details] [review]
pull request 27897

Good work! Please check my comments in github.

Comment 5

[Jamin Liu [:jaliu][:Jamin]]

Comment on attachment 8558909 [details] [review]
pull request 27897

Looks good to me.

Comment 6

[[e-mail], [e-mail]]

Comment on attachment 8558909 [details] [review]
pull request 27897

Arthur, I have updated the patch with you and Jamin's feedback.

The major change are:

* Given definition 'reserved' for those mapping in major device class, but not in minor device class.(All other values reserved)
* Add unit tests.

I will update the change in Bluetooth app after the patch is reviewed. Thanks.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8558909 [details] [review]
pull request 27897

r=me with the comments addressed, thanks!

Comment 8

[[e-mail], [e-mail]]

Since the pull request is landed, we can close the issue now.

Gaia/master:  7622d2cd1866f4326a82afe22e6b8d695a7b9b60