1122430 - Use for..of iteration instead of Array.forEach in ctrlTab.suspendGUI

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

In the ctrlTab.suspendGUI method (https://hg.mozilla.org/mozilla-central/annotate/cac6192956ab/browser/base/content/browser-ctrlTab.js#l399), instead of:

Array.forEach(x, function (y) {
  ...
}, this);

we can do:

for (let y of x) {
  ...
}

Comment 1

[Vikram Jadhav]

Where is the test file for testing this code?
and how can i find test file for any code for my future knowledge?
thanks.

Comment 2

[Vikram Jadhav]

Attachment: Bug1122430_use_for_iteration.diff

All tests passed.
Is this right patch?
Thanks.

Comment 3

[shreyas]

Hi, I would like to work on it.

Comment 4

[Dão Gottwald [:dao]]

(In reply to shreyas from comment #3)
> Hi, I would like to work on it.

Vikram already submitted a patch. How about bug 1122433?

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8550317 [details] [diff] [review]
Bug1122430_use_for_iteration.diff

Thanks!

Comment 6

[Dão Gottwald [:dao]]

(In reply to Vikram Jadhav from comment #1)
> Where is the test file for testing this code?

browser/base/content/test/general/browser_ctrlTab.js

> and how can i find test file for any code for my future knowledge?
> thanks.

This is a little hard to tell. When modifying something in browser/base/, running all tests in browser/base/content/test/general/ or even browser/base/content/test/ is generally a good idea.

Comment 7

[Vikram Jadhav]

Hi,
Is the patch is good? Working
is yes then what should i do next.

Comment 8

[Dão Gottwald [:dao]]

Since you already ran tests, we can just add the checkin-needed keyword.

Comment 9

[Vikram Jadhav]

May i know what is the term "checkin" is?
and i don't know how to add

Comment 10

[Dão Gottwald [:dao]]

(In reply to Vikram Jadhav from comment #9)
> May i know what is the term "checkin" is?

It means that the patch lands on one of our integration branches (and would eventually be merged to mozilla-central).

> and i don't know how to add

I already did it along with comment 8. The "Keywords" field is almost at the top of this page.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/65325797108c

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65325797108c