If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enable test_lockscreen_unlock_to_camera_with_passcode.py

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: edchen, Assigned: Bebe)

Tracking

unspecified
2.2 S4 (23jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.2 fixed, b2g-master fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

3 years ago
Due to Bug 1078270 was fixed, so enable this test script.
(Reporter)

Comment 1

3 years ago
Created attachment 8550214 [details] [review]
PR 27457
Attachment #8550214 - Flags: review?(florin.strugariu)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8550214 [details] [review]
PR 27457

I can't find your branch to test the code.

Have you deleted it or something ?
Attachment #8550214 - Flags: review?(florin.strugariu) → review-
(Assignee)

Comment 3

3 years ago
Comment on attachment 8550214 [details] [review]
PR 27457

The test passes BTW so LGTM
(Reporter)

Comment 4

3 years ago
Created attachment 8551575 [details]
Due to Bug 1078270 was fixed, so enable this test script.
Attachment #8551575 - Flags: review?(florin.strugariu)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8551575 [details]
Due to Bug 1078270 was fixed, so enable this test script.

PR - 27509
(Reporter)

Comment 6

3 years ago
Comment on attachment 8551575 [details]
Due to Bug 1078270 was fixed, so enable this test script.

PR - 27509
(Reporter)

Comment 7

3 years ago
Hi Bebe,

I push PR again, please review again it.

Thanks,
Edward
(Assignee)

Comment 8

3 years ago
this still has issues  Edward  :(( 

edwardchen40 wants to merge 197 commits into mozilla-b2g:v2.2 from edwardchen40:bug1122451
Flags: needinfo?(edchen)
To fix this issue, you need to create first a pull request from edwardchen40:bug1122451 to mozilla-b2g:master. Please make sure your branch has been created from a recent master.
(Reporter)

Comment 10

3 years ago
@Johan, 
Sure, it created from a master.
Flags: needinfo?(edchen)
Okay. In that case, the current problem is: The pull resquest is ready to be merged on 2.2 directly. That's the reason why it says you want to merge 197 commits.  You need to change the branch of your PR to mozilla-b2g:master.

Otherwise, we can't accept the PR in the current state.
Flags: needinfo?(edchen)
(Assignee)

Comment 12

3 years ago
Created attachment 8553740 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27633

Updated this patch with  Edward's commit
jlorenzo can you take a look and review this
Attachment #8553740 - Flags: review?(jlorenzo)
Comment on attachment 8553740 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27633

Looks good to me. test_lockscreen_unlock_to_camera_with_passcode.py is running properly locally.
Attachment #8553740 - Flags: review?(jlorenzo) → review+
Merged in master at https://github.com/mozilla-b2g/gaia/commit/d2d79194fd815b693b22dafedeb60a924ce19dd7.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-v2.2: --- → affected
status-b2g-master: --- → fixed
Resolution: --- → FIXED
Attachment #8550214 - Attachment is obsolete: true
Flags: needinfo?(edchen)
Attachment #8551575 - Attachment is obsolete: true
Attachment #8551575 - Flags: review?(florin.strugariu)
(Reporter)

Comment 15

3 years ago
Hi Johan,

Please help to merge to v2.2 as well.

Thanks,
Edward
Flags: needinfo?(jlorenzo)
Created attachment 8554483 [details] [review]
Gaia PR 2.2
Flags: needinfo?(jlorenzo)
Attachment #8554483 - Flags: review?(florin.strugariu)
Assignee: nobody → florin.strugariu
QA Whiteboard: [fxosqa-auto-s8][fxosqa-auto-points=1]
(Assignee)

Updated

3 years ago
Attachment #8554483 - Flags: review?(florin.strugariu) → review+
(Assignee)

Comment 17

3 years ago
Merge when tree reopens
Flags: needinfo?(florin.strugariu)
(Assignee)

Comment 18

3 years ago
https://github.com/mozilla-b2g/gaia/commit/6f4e616d6ad0ae2e8958d2c6e49277fc6d8f67a1
Flags: needinfo?(florin.strugariu)
Please don't forget to set the status flags when doing branch uplifts.
status-b2g-v2.2: affected → fixed
Target Milestone: --- → 2.2 S4 (23jan)
You need to log in before you can comment on or make changes to this bug.