1122453 - Re-organize the APIs in ViewManager

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #1115247 +++

See Bug #1115247 comment 2, we need to re-organize the APIs that are exposed by viewManager.
 - One thing I remember is that we should not return an instance of AlternativesCharMenuView from the viewManager.
 - Another one is LayoutRenderingManager should be the only client of viewManager.

Not sure if these are all that we can do in this, but will try to get started.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: WIP

Tim,

This is a WIP to refine the APIs, please help give any advice if you could help.
Thanks.

Please help look at this commit, since the previous patch has not landed yet.
https://github.com/RudyLu/gaia/commit/37c3368a8f8a9db7b4fac2a8aab4e95dcd3f90b2

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8551167 [details] [review]
WIP

There are other stuff as well, for example the responsibility and APIs between rendering manager and view manager are not clear; the draw() function takes a callback which is the only place we take callback (all other callbacks are converted to promises already). There is also a problem we accidentally chain the requestAnimationFrame() to the promise chain and actually waits for the rendering before showing the keyboard. The list goes on if you understand the code enough. Please be opinionated and use your judgement to propose fixes. I really don't have the time to find a explicit list for you, unfortunately.

If you really can't do it, you should probably work on Emoji layout first after bug 1115247.

Comment 3

[BMO Automation]

Firefox OS is not being worked on