Closed Bug 1122559 Opened 10 years ago Closed 10 years ago

User proper plural form for active downloads warning when exiting Private Browsing

Categories

(Firefox :: Private Browsing, defect)

Product:
Firefox
Component:
Private Browsing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: flod, Unassigned)

References

Details

The error was there before bug 1115717, but I never noticed it (need to check if there's a bug around). Why are we not using a proper plural form? We should *never* use 2 strings to differentiate singular from plural. https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Use_proper_plural_forms leavePrivateBrowsingWindowsCancelDownloadsAlertMsg2=If you close all Private Browsing windows now, 1 download will be canceled. Are you sure you want to leave Private Browsing? leavePrivateBrowsingWindowsCancelDownloadsAlertMsgMultiple2=If you close all Private Browsing windows now, %S downloads will be canceled. Are you sure you want to leave Private Browsing?
Argh, found the reason, fooled by the diff :-\ # LOCALIZATION NOTE: we don't have proper plural support in the CPP code; bug 463102
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
This code should now be handled in js http://mxr.mozilla.org/mozilla-central/source/toolkit/components/jsdownloads/src/DownloadUIHelper.jsm#215 So this is fixable in jsdownloads, not fixable in the old API, but we are deprecating the old API and not using it anymore.
could just be solved as a dupe of bug 463102, I guess. We could introduce new pluralized strings and use the new strings in jsdownloads.
If it's fixable, probably duping is a good idea (and wontfixing bug 463109?) In that file we have 10 strings that should become 5 with plural forms (if I counted them right).
(In reply to Francesco Lodolo [:flod] from comment #1) > # LOCALIZATION NOTE: we don't have proper plural support in the CPP code; > bug 463102 Yes, that. But we're definitely removing the C++ code as a result of bug 851471. I filed bug 1122592 for the whole story.
You need to log in before you can comment on or make changes to this bug.