112281 - ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jeremy M. Dolan]

At the URL, unselect all of the datasets. Now, click NEW, hold shift, click
ASSIGNED. Release shift, hold control, click UNCONFIRMED.

Three datasets are now selected.

Hold control AND shift, click RESOLVED.

What happens: only the last range, UNCONFIRMED-RESOLVED are selected.
What should happen: All four should be selected.

Comment 1

[Jeremy M. Dolan]

Range select seems to wipe out everything else, even if they were selected
indivudually (ie, the top two were selected with control). Resummarizing.

Comment 2

[John Morrison]

-> HTML Form Controls

Oh, my gosh! What does Ctrl-Alt-Shift-DoubleClick do?

Comment 3

[John Morrison]

-> HTML Form Controls

Comment 4

[John Morrison]

I stupid.

Comment 5

[TucsonTester3]

Attachment: reduced testcase

I am also seeing this on:
Windows 98 OSR 2.5
Netscape Build: 2001121003

Comment 6

[rods (gone)]

john, can you take a look?

Comment 7

[John Keiser (jkeiser)]

Should be fixed with bug 40983 (checkin soon).

Comment 8

[Jeremy M. Dolan]

Linux 2002011008, shift still overriding ctrl.

Comment 9

[John Keiser (jkeiser)]

Yes, 'tis true, that bug didn't fix it. I think I misunderstood this bug when I
first read it.  The XBL select (bug 112713, in the tree already but not yet
turned on) should fix this and will at the very least obsolete anything I do now
when it is turned on; so I am loathe to work on this until it lands.

Comment 10

[Gérard Talbot]

Bug 120388 is extremely similar to this bug, except for only one word: at the
last step, the reporter says shift+click (the last item of the list).

I think bug 120388 and this bug should be merged into 1 single bug.

Comment 11

[Gérard Talbot]

Please ignore my previous comment (comment #10). I missed an important detail
about both bugs. Very sorry for the spam.

Comment 12

[lsof]

I get the same. It makes Mozilla less efficient to use than IE for list selection :/
2002072204

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 135533 [details] [diff] [review]
Proposed patch

roc, what do you think?

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 135533 [details] [diff] [review]
Proposed patch

looks quite straighforward :-)

Comment 16

[Boris Zbarsky [:bzbarsky]]

Taking

Comment 17

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 18

[Jeremy M. Dolan]

looks good. v.