Closed Bug 1122829 Opened 6 years ago Closed 6 years ago
Tighten vertical spacing of Android Firefox Accounts sign up/sign flow
57 bytes, text/x-github-pull-request
|Details | Review|
The Android Firefox Accounts sign up/sign in flow doesn't usually fit on one screen. It can be pretty hard to tell there's "more" when this happens. We should shrink padding, margins, and text sizes; and hide the error display until it's needed.
This ended up being a laundry list. I'm not sure it's really worth *reviewing*, per se -- but it's definitely worth spinning through a few FxA screens (getting started, sign up, sign in, maybe re-enter credentials) to see how it looks and feels. I intend to test a little on tablets, too.
Attachment #8550618 - Flags: review?(rnewman)
Comment on attachment 8550618 [details] [review] Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/524 I don't see anything terrifying about the code. Land it in Nightly and we'll revise if needed.
Attachment #8550618 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.