1122829 - Tighten vertical spacing of Android Firefox Accounts sign up/sign flow

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Firefox Accounts, defect)

Description

[Nick Alexander :nalexander [he/him]]

The Android Firefox Accounts sign up/sign in flow doesn't usually fit on one screen.  It can be pretty hard to tell there's "more" when this happens.  We should shrink padding, margins, and text sizes; and hide the error display until it's needed.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/524

This ended up being a laundry list.  I'm not sure it's really worth *reviewing*, per se -- but it's definitely worth spinning through a few FxA screens (getting started, sign up, sign in, maybe re-enter credentials) to see how it looks and feels.  I intend to test a little on tablets, too.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8550618 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/524

I don't see anything terrifying about the code. Land it in Nightly and we'll revise if needed.

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/0dc5bc00a9f8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0dc5bc00a9f8