1122850 - Use setPowerMode interface for HWC 1.4 and above

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Inder]

For HWC version 1.4 and above, HAL does not support blank interface.
Hence, setPowerMode() should be used in place of blank().

Comment 1

[Sushil]

Attachment: Use setPowerMode interface for HWC 1.4 and above.

For HWC version 1.4 and above, HAL does not support blank interface. Hence, setPowerMode() should be used in place of blank().

Comment 2

[Diego Wilson [:diego]]

Comment on attachment 8559972 [details] [diff] [review]
Use setPowerMode interface for HWC 1.4 and above.

LGTM

Comment 3

[Sushil]

Attachment: Use setPowerMode interface for HWC 1.4 and above. r=dwilson

Uploading the HG version of the reviewed patch.

Comment 4

[Sushil]

Try server link: https://tbpl.mozilla.org/?tree=Try&rev=a466025f55a0

Comment 5

[Sushil]

NI to get "blocking-b2g: 2.2?" approval.

Comment 6

[Sushil]

Comment on attachment 8560030 [details] [diff] [review]
Use setPowerMode interface for HWC 1.4 and above. r=dwilson

Review of attachment 8560030 [details] [diff] [review]:
-----------------------------------------------------------------

[Approval Request Comment]
Bug caused by (feature/regressing bug #): As per Android Lollipop HWC header, HAL does not support blank interface for HWC version 1.4 and above.
User impact if declined: Issues in black/un-blank use-case (suspend/resume), if it is HWC 1.4 HAL.
Testing completed: Basic display testing.
Risk to taking this patch (and alternatives if risky): No
String or UUID changes made by this patch: No

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3d85bc28eaad

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d85bc28eaad

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ee6fd0f49501