1122857 - form controls fail to emit TYPE_VIEW_CLICKED events upon state change.

Status: RESOLVED FIXED

Description

[Drew]

Confirmed on Kitkat, with firefox nightlies. Example page:
http://www.tizag.com/htmlT/htmlcheckboxes.php
A more in-depth discussion on the issue, with a screenreader patch:
https://groups.google.com/forum/#!topic/spielproject/aCcnm_Y48Ow

Comment 1

[Peter Vágner]

Steps to reproduce:
Open a website where there are some checkboxes or radio buttons in nightly.
Use your favorite method of navigation to reach a checkbox and observe its state checked or unchecked.
Now double tap anywhere on the screen in order to change the state of that checkbox.

Results:
checkbox will toggle the state but you will receive no feetback from your screen reader.

Expected results:
Your screen reader will announce new state as you double tap on a radio button and / or a checkbox.

Comment 2

[Marco Zehe (:MarcoZ)]

Eitan, Max, are there any historic reasons we emit the event when clicking a button, but not when togling a checkbox?

Comment 3

[Max Li [:maxli]]

It appears we explicitly don't send it out and instead use a state change event.

https://mxr.mozilla.org/mozilla-central/source/accessible/jsat/Presentation.jsm#318

Comment 4

[Eitan Isaacson [:eeejay]]

This should get fixed. We have a special case for toggle controls as Max points out. Apparently it is broken.

Comment 5

[Max Li [:maxli]]

Created attachment 8565624 [details] [diff] [review]
Patch

It seems like the check to prevent sending this was mistakenly added, since the state change event which we depend on explicitly calls the actionInvoked presenter.

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8565624 [details] [diff] [review]
Patch

Review of attachment 8565624 [details] [diff] [review]:
-----------------------------------------------------------------

This looks right. Thanks!

Comment 7

[Eitan Isaacson [:eeejay]]

Actually, one nit: could you write a comment on why the text is empty when the object is checkable?

Comment 8

[Max Li [:maxli]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41b3823ec717

Comment 9

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/41b3823ec717