Closed Bug 1122931 Opened 5 years ago Closed 5 years ago

Don't overwrite the AS variable in toolchain.m4; r=glandium

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It looks like overwriting AS here is not intentional.  Before this patch,
it is impossible to override AS through mozconfig for anything that runs
past this stage in configure.
Assignee: nobody → ehsan
Blocks: msvcwine
Attachment #8550745 - Flags: review?(mh+mozilla)
Comment on attachment 8550745 [details] [diff] [review]
Don't overwrite the AS variable in toolchain.m4

Review of attachment 8550745 [details] [diff] [review]:
-----------------------------------------------------------------

You should put all those cross-msvc patches in one bug, or even one patch, because reviewing many one liners is not very efficient.
Attachment #8550745 - Flags: review?(mh+mozilla) → review+
(BTW, how did you install msvc on linux? the installer won't start in wine here)
(In reply to Mike Hommey [:glandium] from comment #2)
> Comment on attachment 8550745 [details] [diff] [review]
> Don't overwrite the AS variable in toolchain.m4
> 
> Review of attachment 8550745 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> You should put all those cross-msvc patches in one bug, or even one patch,
> because reviewing many one liners is not very efficient.

These are just the easy ones.  :-)  There are more extensive changes that I have not put up yet because I'm not happy with them yet.

(In reply to Mike Hommey [:glandium] from comment #3)
> (BTW, how did you install msvc on linux? the installer won't start in wine
> here)

The installer hits https://bugs.winehq.org/show_bug.cgi?id=33576.  What I did was install things on Windows using the Chromium installation script (which is amazing!) and then copy the files over to Linux with a few tweaks.  I will blog about the instructions soon, but first I need to try to install MSVC 2013 Update 4 (what the Chromium scripts install is a previous update, it seems.)
https://hg.mozilla.org/mozilla-central/rev/6f8c5e3ddadb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.