1122931 - Don't overwrite the AS variable in toolchain.m4; r=glandium

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

It looks like overwriting AS here is not intentional.  Before this patch,
it is impossible to override AS through mozconfig for anything that runs
past this stage in configure.

Comment 1

[(no longer active)]

Attachment: Don't overwrite the AS variable in toolchain.m4

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8550745 [details] [diff] [review]
Don't overwrite the AS variable in toolchain.m4

Review of attachment 8550745 [details] [diff] [review]:
-----------------------------------------------------------------

You should put all those cross-msvc patches in one bug, or even one patch, because reviewing many one liners is not very efficient.

Comment 3

[Mike Hommey [:glandium]]

(BTW, how did you install msvc on linux? the installer won't start in wine here)

Comment 4

[(no longer active)]

(In reply to Mike Hommey [:glandium] from comment #2)
> Comment on attachment 8550745 [details] [diff] [review]
> Don't overwrite the AS variable in toolchain.m4
> 
> Review of attachment 8550745 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> You should put all those cross-msvc patches in one bug, or even one patch,
> because reviewing many one liners is not very efficient.

These are just the easy ones.  :-)  There are more extensive changes that I have not put up yet because I'm not happy with them yet.

(In reply to Mike Hommey [:glandium] from comment #3)
> (BTW, how did you install msvc on linux? the installer won't start in wine
> here)

The installer hits https://bugs.winehq.org/show_bug.cgi?id=33576.  What I did was install things on Windows using the Chromium installation script (which is amazing!) and then copy the files over to Linux with a few tweaks.  I will blog about the instructions soon, but first I need to try to install MSVC 2013 Update 4 (what the Chromium scripts install is a previous update, it seems.)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f8c5e3ddadb