1122983 - UITour for search bar is not localized on Firefox 35

Status: RESOLVED WONTFIX

(Firefox :: Search, defect)

Description

[Théo Chevalier]

Attachment: Screenshot Firefox 35, French

If you trigger UITour for search in French build (for instance) of Firefox 35, the 2 popups are in English, see attached screenshot.

Tested on Release channel on Ubuntu and Windows for both French and Italian locales: it's in English. Looks like we missed that in bug 1107278.

We can't do anything for Firefox 35, but I'm filing the bug to make sure it's fixed on Firefox 36.

Comment 1

[Francesco Lodolo [:flod]]

Argh, the strings weren't uplifted to beta in last cycle :-\
http://hg.mozilla.org/releases/mozilla-release/file/c13c3b4992cf/browser/locales/en-US/chrome/browser/searchbar.dtd

I think that's already fixed for 36, since the strings are there
http://hg.mozilla.org/releases/mozilla-beta/file/default/browser/locales/en-US/chrome/browser/searchbar.dtd

Comment 2

[Florian Quèze [:florian]]

Sorry for completely forgetting about the UITour thing when I worked on bug 1107278 :-(.

The changeset that landed on beta for 35 is https://hg.mozilla.org/releases/mozilla-beta/rev/f74374acec82 and has the strings hardcoded. The changeset that landed for 36 is http://hg.mozilla.org/mozilla-central/rev/edb694f470b8 and has the strings localized correctly.

I don't think there's anything we can or need to do here.