1123013 - IntelliJ needs Project SDK set due to dynamic code in android.gradle

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

Sigh.  IntelliJ fishes the Project SDK versions, including the Java language, Android platform, and build tool versions, manually from build.gradle.  That's right, it parses it in some separate ad-hoc manner, rather than interrogating the Gradle model.  I hope the reason justifies the clown shoes.

What this means is that the dynamic settings we apply from mobile/android/gradle/android.gradle are not seen by the IDE (they are seen by the Gradle build just fine).  That in turn means that the user needs to set the Project SDK, and that appears to race against reading the Gradle configuration on some platforms, namely Linux (as reported by mcomella).

The fix is to hard-code the relevant settings (duplicated, sigh) into every build.gradle file.  That's tricky, because we haven't yet pinned the versions (see Bug 1108782), so we may trample local developer choices.  Overall, I think it's worth it.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: bz://1123013/nalexander

Comment 2

[Nick Alexander :nalexander [he/him]]

/r/2673 - Bug 1123013 - WIP on hard coding Android versions.

Pull down this commit:

hg pull review -r a51d6904bab9ba063b5c871bd137b112d9787d2b

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8551417 [details]
MozReview Request: bz://1123013/nalexander

Looks like Review Board doesn't let you ask for feedback.  This is a hack but will help us understand if the simple thing is sufficient for your case, mcomella.  Apply the patch and then re-import into IntelliJ.  You should see the "root project" have no SDK, but all the "child projects" should have the Android 21 SDK.  If you look at the patch, I'm hard-coding the build-tools to be "21.1.1" as well.  You'll need that (and android-21); install with the |android| tool if necessary.  Thanks!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8551417 [details]
MozReview Request: bz://1123013/nalexander

It appears to be working for me - the only red squiggles I see are for API version mis-matches (e.g. API level for call is 10, minimum set is 9). The class files in the project view do not indicate failures so it looks like they've otherwise compiled successfully.

The .gradle directory is red in the project view, but it doesn't seem to be negatively affecting anything.

(In reply to Nick Alexander :nalexander from comment #3)
> You should see the "root project" have no SDK, but all the
> "child projects" should have the Android 21 SDK.

Not sure what you mean by this.

Thanks Nick!

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #4)
> Comment on attachment 8551417 [details]
> MozReview Request: bz://1123013/nalexander
> 
> It appears to be working for me - the only red squiggles I see are for API
> version mis-matches (e.g. API level for call is 10, minimum set is 9). The
> class files in the project view do not indicate failures so it looks like
> they've otherwise compiled successfully.
> 
> The .gradle directory is red in the project view, but it doesn't seem to be
> negatively affecting anything.

I think that's "light pinky red" for not included in the project (automatically), not "dark red/squiggly" for causing problems.  That's appropriate; .gradle is just a cache directory.

> 
> (In reply to Nick Alexander :nalexander from comment #3)
> > You should see the "root project" have no SDK, but all the
> > "child projects" should have the Android 21 SDK.
> 
> Not sure what you mean by this.

If you look in "Project Structure", the project as a whole and the "gradle" project may have no SDK, but all the other projects ("base", "stumbler", etc) will have SDKs.  It's not a big deal.

Thanks for testing!

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/21ab618e06ad

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/21ab618e06ad

Comment 9

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1123013 - WIP on hard coding Android versions.