1123017 - Avoid printing a trailing newline from milestone.py when running with a Windows python; r=gps

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Comment 1

[(no longer active)]

Attachment: Avoid printing a trailing newline from milestone.py when running with a Windows python

Comment 2

[Mike Hommey [:glandium]]

Why? Because now, what this does is that it doesn't print a newline at all. On any platform.

So what problem exactly are you trying to solve? That it outputs \r\n and you'd rather the \r not to be there?

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8550827 [details] [diff] [review]
Avoid printing a trailing newline from milestone.py when running with a Windows python

Review of attachment 8550827 [details] [diff] [review]:
-----------------------------------------------------------------

Something is amiss here. Perl doesn't print newlines by default. `perl -e 'print "foo"' | hexdump -C`

What you should do is put all the prints in a new block with $\ set to undef. e.g.

{
  local $\ = undef;
  print(...);
}

Comment 5

[(no longer active)]

Hmm, where does perl enter the picture here?  I'm not sure if I follow.

Comment 6

[Gregory Szorc [:gps]]

Ignore my stupidity. The flu has been ravaging me. You can do:

  print('foo', end='') to avoid printing a newline.

Comment 7

[(no longer active)]

OK, thanks!  I will wait first for bug 1124906 to come to a resolution...