1123079 - Count the number of locales updated

Status: RESOLVED FIXED

(Marketing :: Copy, task)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: 3568.diff

Instead of:
18:13:49     INFO - Running main action method: update_apk_description
18:13:51     INFO - Updating org.mozilla.firefox for 'sl' /  title: 'Firefox za Android', short_desc: 'Mi izdelujemo Firefo'..., long_desc: 'Mi izdelujemo Firefo...'
18:13:55     INFO - Edit "00377195244275974873" has been committed.

It now shows:
18:13:49     INFO - Running main action method: update_apk_description
18:13:51     INFO - Updating org.mozilla.firefox for 'sl' /  title: 'Firefox za Android', short_desc: 'Mi izdelujemo Firefo'..., long_desc: 'Mi izdelujemo Firefo...'
18:13:55     INFO - Edit "00377195244275974873" has been committed. 1 locale(s) updated.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8550909 [details] [diff] [review]
3568.diff

Review of attachment 8550909 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/update_apk_description.py
@@ +187,5 @@
>                      editId=edit_id, packageName=package_name, language=locale,
>                      body={'fullDescription': long_desc,
>                            'shortDescription': short_desc,
>                            'title': title}).execute()
> +                nb_locales = nb_locales + 1

Python doesn't have ++, but it has +=. You can use that if you want, but this is totally fine too.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8550909 [details] [diff] [review]
3568.diff

http://hg.mozilla.org/build/mozharness/rev/4cf761a3fa29

Comment 4

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/mozharness/rev/4cf761a3fa29

Comment 5

[Sylvestre Ledru [:Sylvestre]]

And it is working. Thanks