1123093 - Include build ID and version info in debug logs

Status: RESOLVED FIXED

(Chat Core :: General, enhancement)

Comment 1

[aleth [:aleth]]

Attachment: debuginfo.diff

Comment 2

[aleth [:aleth]]

Attachment: debuginfo.diff v2

Better not hardcode "Instantbird" because of TB ;)

Comment 3

[Patrick Cloke [:clokep]]

This looks reasonable, just curious if you saw flo's comment on IRC [1]:
19:35:25 <flo-retina> what's used by the update service?
19:36:17 <flo-retina> seems to be http://hg.mozilla.org/mozilla-central/file/459040b37060/toolkit/components/urlformatter/nsURLFormatter.js#l57

[1] http://log.bezut.info/instantbird/150118/#m198

Comment 4

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #3)
> This looks reasonable, just curious if you saw flo's comment on IRC [1]:
> 19:35:25 <flo-retina> what's used by the update service?
> 19:36:17 <flo-retina> seems to be
> http://hg.mozilla.org/mozilla-central/file/459040b37060/toolkit/components/
> urlformatter/nsURLFormatter.js#l57

I saw it, but it didn't seem like a simplification to me, so unless it has other advantages...

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8550985 [details] [diff] [review]
debuginfo.diff v2

Review of attachment 8550985 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. I find the unshift a little bit odd, but couldn't see any way to simplify the logic.

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/adcfb9a1a252