Closed Bug 1123093 Opened 9 years ago Closed 9 years ago

Include build ID and version info in debug logs

Categories

(Chat Core :: General, enhancement)

Product:
Chat Core
Component:
General
Platform:
x86
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file, 1 obsolete file)

debuginfo.diff v2
2.02 KB, patch
clokep
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch debuginfo.diff (obsolete) — — Splinter Review 
Assignee: nobody → aleth
Status: NEW → ASSIGNED

        Attachment #8550923 -
        Flags: review?(clokep)

    
    

    
  


  
Better not hardcode "Instantbird" because of TB ;)

        Attachment #8550923 -
        Attachment is obsolete: true

        Attachment #8550923 -
        Flags: review?(clokep)

        Attachment #8550985 -
        Flags: review?(clokep)

    
    

    
  
This looks reasonable, just curious if you saw flo's comment on IRC [1]:
19:35:25 <flo-retina> what's used by the update service?
19:36:17 <flo-retina> seems to be http://hg.mozilla.org/mozilla-central/file/459040b37060/toolkit/components/urlformatter/nsURLFormatter.js#l57

[1] http://log.bezut.info/instantbird/150118/#m198

    
    

    
  
(In reply to Patrick Cloke [:clokep] from comment #3)
> This looks reasonable, just curious if you saw flo's comment on IRC [1]:
> 19:35:25 <flo-retina> what's used by the update service?
> 19:36:17 <flo-retina> seems to be
> http://hg.mozilla.org/mozilla-central/file/459040b37060/toolkit/components/
> urlformatter/nsURLFormatter.js#l57

I saw it, but it didn't seem like a simplification to me, so unless it has other advantages...

    
    

    
  
Comment on attachment 8550985 [details] [diff] [review]
debuginfo.diff v2

Review of attachment 8550985 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. I find the unshift a little bit odd, but couldn't see any way to simplify the logic.

        Attachment #8550985 -
        Flags: review?(clokep) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: