Closed Bug 1123116 Opened 5 years ago Closed 5 years ago
Account Status Fragment to support reading list
57 bytes, text/x-github-pull-request
|Details | Review|
This ticket tracks surfacing the Firefox Account and reading list status to the user. The natural place to do that is to expose reading list state in the Status Activity. We could also surface just enough Firefox Account details -- healthy (green/red) and a link to the relevant status activity -- in the Settings > Reading List section to keep the RL configuration separate. That is, we can go Settings * Firefox Account ** Sync ** Reading List or Settings * Sync * Reading List * Firefox Account with Sync and Reading List surfacing just a bit of Firefox Account and a deep link. If we move the RL configuration into the Status Activity, we should consider splitting the existing fragment into "Account-specific" and "Sync service specific" facets (possibly sub-fragments). The status fragment is groaning under the accumulated weight of being heavily tied to Sync. If we keep the RL configuration separate from the Status Activity, we should probably extract the Sync status out of that activity.
Last few commits are over to you, rnewman. This adds the RL checkbox to the sign up flow and to the status activity. It's the minimal effort in this area -- I could imagine trying to surface the Sync and Reading List service status more explicitly, and trying to improve the status activity to reflect the separate statuses better.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8561753 - Flags: review?(rnewman)
Comment on attachment 8561753 [details] [review] Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/530 Per my discussion with rnewman on GH and IRC, I'm happy with the code I landed in the event that we toggle the build flag multiple times in future, so I'm marking r+.
Attachment #8561753 - Flags: review?(rnewman) → review+
You need to log in before you can comment on or make changes to this bug.