1123137 - Services.HealthReport.HealthReporter "No prefs data found." probably doesn't need to be a warning

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Matthew N. [:MattN]]

IIUC, my understanding is that "No prefs data found." is the common case for all new profiles and profiles after the one-time migration so I don't think it makes sense to spam the Browser Console on every startup about this (especially years after the migration code was released).

I propose that the message be logged at a lower verbosity (lower than the current default console log level of "Warn".

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1123137/MattN

Comment 2

[Matthew N. [:MattN]]

/r/2655 - Bug 1123137 - Switch "No prefs data found." health report warning to debug output. r=gps

Pull down this commit:

hg pull review -r 6630019d3913eb8baa81edfc9fbba0802d27f260

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8550982 [details]
MozReview Request: bz://1123137/MattN

I can go either way on this change. But I'm not in the daily grind of FHR any more.

Comment 4

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8550982 [details]
MozReview Request: bz://1123137/MattN

https://reviewboard.mozilla.org/r/2653/#review2339

Ship It!

Comment 5

[Matthew N. [:MattN]]

Thanks.

https://hg.mozilla.org/integration/fx-team/rev/ab1d6b15c5ed

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab1d6b15c5ed

Comment 8

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1123137 - Switch "No prefs data found." health report warning to debug output. r=gps