1123198 - abort() must call the reset parser state algorithm

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

Per spec:
http://w3c.github.io/media-source/#widl-SourceBuffer-abort-void

"When this method is invoked, the user agent must run the following steps:

    1.If this object has been removed from the sourceBuffers attribute of the parent media source then throw an InvalidStateError exception and abort these steps.
    2.If the readyState attribute of the parent media source is not in the "open" state then throw an InvalidStateError exception and abort these steps.
    3.If the updating attribute equals true, then run the following steps:
        Abort the buffer append and stream append loop algorithms if they are running.
        Set the updating attribute to false.
        Queue a task to fire a simple event named abort at this SourceBuffer object.
        Queue a task to fire a simple event named updateend at this SourceBuffer object.
    4.Run the reset parser state algorithm.
    5.Set appendWindowStart to the presentation start time.
    6.Set appendWindowEnd to positive Infinity.
"

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Run reset parser state algorithm when aborting

Run Reset Parser State Algorithm when aborting. Currently that routine does nothing (bug 1122358)

Comment 2

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ebc8ccaf3ea4

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ebc8ccaf3ea4

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8551087 [details] [diff] [review]
Run reset parser state algorithm when aborting

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: This is a one-line fix for a spec compliance issue and MSE-specific.
[String/UUID change made/needed]: None.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e3fd7a5f3fac
https://hg.mozilla.org/releases/mozilla-beta/rev/17830430e6be