Closed Bug 1123198 Opened 6 years ago Closed 6 years ago

abort() must call the reset parser state algorithm

Categories

(Core :: Audio/Video, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- fixed
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Per spec:
http://w3c.github.io/media-source/#widl-SourceBuffer-abort-void

"When this method is invoked, the user agent must run the following steps:

    1.If this object has been removed from the sourceBuffers attribute of the parent media source then throw an InvalidStateError exception and abort these steps.
    2.If the readyState attribute of the parent media source is not in the "open" state then throw an InvalidStateError exception and abort these steps.
    3.If the updating attribute equals true, then run the following steps:
        Abort the buffer append and stream append loop algorithms if they are running.
        Set the updating attribute to false.
        Queue a task to fire a simple event named abort at this SourceBuffer object.
        Queue a task to fire a simple event named updateend at this SourceBuffer object.
    4.Run the reset parser state algorithm.
    5.Set appendWindowStart to the presentation start time.
    6.Set appendWindowEnd to positive Infinity.
"
Run Reset Parser State Algorithm when aborting. Currently that routine does nothing (bug 1122358)
Attachment #8551087 - Flags: review?(cajbir.bugzilla)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Attachment #8551087 - Flags: review?(cajbir.bugzilla) → review+
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/ebc8ccaf3ea4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8551087 [details] [diff] [review]
Run reset parser state algorithm when aborting

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: This is a one-line fix for a spec compliance issue and MSE-specific.
[String/UUID change made/needed]: None.
Attachment #8551087 - Flags: approval-mozilla-beta?
Attachment #8551087 - Flags: approval-mozilla-aurora?
Attachment #8551087 - Flags: approval-mozilla-beta?
Attachment #8551087 - Flags: approval-mozilla-beta+
Attachment #8551087 - Flags: approval-mozilla-aurora?
Attachment #8551087 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.