abort() must call the reset parser state algorithm

RESOLVED FIXED in Firefox 36

Status

()

defect
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks 1 bug)

Trunk
mozilla38
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed, firefox38 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
Per spec:
http://w3c.github.io/media-source/#widl-SourceBuffer-abort-void

"When this method is invoked, the user agent must run the following steps:

    1.If this object has been removed from the sourceBuffers attribute of the parent media source then throw an InvalidStateError exception and abort these steps.
    2.If the readyState attribute of the parent media source is not in the "open" state then throw an InvalidStateError exception and abort these steps.
    3.If the updating attribute equals true, then run the following steps:
        Abort the buffer append and stream append loop algorithms if they are running.
        Set the updating attribute to false.
        Queue a task to fire a simple event named abort at this SourceBuffer object.
        Queue a task to fire a simple event named updateend at this SourceBuffer object.
    4.Run the reset parser state algorithm.
    5.Set appendWindowStart to the presentation start time.
    6.Set appendWindowEnd to positive Infinity.
"
Assignee

Comment 1

5 years ago
Run Reset Parser State Algorithm when aborting. Currently that routine does nothing (bug 1122358)
Attachment #8551087 - Flags: review?(cajbir.bugzilla)
Assignee

Updated

5 years ago
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED

Updated

5 years ago
Attachment #8551087 - Flags: review?(cajbir.bugzilla) → review+

Updated

5 years ago
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/ebc8ccaf3ea4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8551087 [details] [diff] [review]
Run reset parser state algorithm when aborting

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: This is a one-line fix for a spec compliance issue and MSE-specific.
[String/UUID change made/needed]: None.
Attachment #8551087 - Flags: approval-mozilla-beta?
Attachment #8551087 - Flags: approval-mozilla-aurora?
Attachment #8551087 - Flags: approval-mozilla-beta?
Attachment #8551087 - Flags: approval-mozilla-beta+
Attachment #8551087 - Flags: approval-mozilla-aurora?
Attachment #8551087 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.