1123374 - Strange log: CertBlocklist::Init certList path: /home/mozilla/.mozilla/firefox/78bj0l2l.test5/revocations.txt....

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Dragana Damjanovic [:dragana]]

looking at something else, I  hsave seen this strange log:


CertBlocklist::Init certList path: /home/mozilla/.mozilla/firefox/78bj0l2l.test5/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocatio.....


Maybe it is just a log...

Comment 1

[Dana Keeler (she/her) [:keeler] (out until 16 June)]

Attachment: patch

It turns out, if revocations.txt doesn't exist, we end up repeatedly appending "/revocations.txt" to the file path and seeing if that exists, which it obviously doesn't. This reorganizes the initialization logic such that this is no longer possible.

Comment 2

[Dana Keeler (she/her) [:keeler] (out until 16 June)]

Looks like this is causing crashes: see bug 1123838.

Comment 3

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8551917 [details] [diff] [review]
patch

Review of attachment 8551917 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 4

[Dana Keeler (she/her) [:keeler] (out until 16 June)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9abd37866239

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9abd37866239

Comment 6

[Dana Keeler (she/her) [:keeler] (out until 16 June)]

Comment on attachment 8551917 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: OneCRL (bug 1024809)
[User impact if declined]: OOM crashes (see bug 1123838)
[Describe test coverage new/current, TreeHerder]: no automated tests (but you can set the environment variable NSPR_LOG_MODULES to "CertBlock:5" and verify that you don't see anything like what's in comment 0)
[Risks and why]: low - this feature isn't actually being used yet
[String/UUID change made/needed]: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d5403861ce26

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Setting tracing 37 due to dup bug 1123838.

Comment 10

[Sladky Vladimir]

Version 20150225 is always slow and i mus use old 20141114 :-(
In Safe Mode too - how to i test what is wrong please ??? 

https://bugzilla.mozilla.org/show_bug.cgi?id=1134327