Closed Bug 1123374 Opened 6 years ago Closed 6 years ago

Strange log: CertBlocklist::Init certList path: /home/mozilla/.mozilla/firefox/78bj0l2l.test5/revocations.txt....

Categories

(Core :: Security, defect)

Product:
Core
Component:
Security
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox36 --- unaffected
firefox37 + fixed
firefox38 --- fixed

People

(Reporter: dragana, Assigned: keeler)

References

Details

Attachments

(1 file)

patch
6.42 KB, patch
mgoodwin
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
looking at something else, I  hsave seen this strange log:


CertBlocklist::Init certList path: /home/mozilla/.mozilla/firefox/78bj0l2l.test5/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocations.txt/revocatio.....


Maybe it is just a log...
Attached patch patch — — Splinter Review 
It turns out, if revocations.txt doesn't exist, we end up repeatedly appending "/revocations.txt" to the file path and seeing if that exists, which it obviously doesn't. This reorganizes the initialization logic such that this is no longer possible.
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #8551917 - Flags: review?(mgoodwin)
Looks like this is causing crashes: see bug 1123838.
status-firefox37: --- → affected
status-firefox38: --- → affected
Comment on attachment 8551917 [details] [diff] [review]
patch

Review of attachment 8551917 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8551917 - Flags: review?(mgoodwin) → review+
https://hg.mozilla.org/mozilla-central/rev/9abd37866239
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8551917 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: OneCRL (bug 1024809)
[User impact if declined]: OOM crashes (see bug 1123838)
[Describe test coverage new/current, TreeHerder]: no automated tests (but you can set the environment variable NSPR_LOG_MODULES to "CertBlock:5" and verify that you don't see anything like what's in comment 0)
[Risks and why]: low - this feature isn't actually being used yet
[String/UUID change made/needed]: none
Attachment #8551917 - Flags: approval-mozilla-aurora?
Attachment #8551917 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 1123838
Setting tracing 37 due to dup bug 1123838.
tracking-firefox37: --- → +
Version 20150225 is always slow and i mus use old 20141114 :-(
In Safe Mode too - how to i test what is wrong please ??? 

https://bugzilla.mozilla.org/show_bug.cgi?id=1134327
You need to log in before you can comment on or make changes to this bug.