1123431 - Use case-insensitive search for filtering passwords on about:passwords

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Description

[:Margaret Leibovic]

See bug 1101741 comment 27.

Comment 1

[vaibhav [:vaibhavChoudhary]]

:Margaret i would really like to work on this bug.I m new to open source and i think this can help me to further venture in open source world.

Comment 2

[:Margaret Leibovic]

(In reply to vaibhav [:vaibhavChoudhary] from comment #1)
> :Margaret i would really like to work on this bug.I m new to open source and
> i think this can help me to further venture in open source world.

Hi vaibhav! Sorry for the slow response, I was traveling, and I'm just catching up on things now.

First of all, you'll want to set up a Firefox for Android build environment. You can find instructions for that here:
https://wiki.mozilla.org/Mobile/Fennec/Android

Please join us in #mobile on irc.mozilla.org to ask questions if you run into any issues getting a build set up. Also feel free to say hi to introduce yourself!

To fix this bug, you'll want to take a look at the filtering code here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutPasswords.js#246

To fix this, I think we just need to make the query text lowercase, since we already make the login data lowercase as well.

Feel free to ask Chenxia (liuche on IRC) more questions, since she owns this code :)

Comment 3

[Chenxia Liu [:liuche]]

Hi vaibhav! Were you still interested in working on this bug? Someone else asked me about it, and I wanted to make sure you haven't started it already.

Comment 4

[vaibhav [:vaibhavChoudhary]]

Margaret no i haven't started working on this bug.I would appreciate if you can pass it to someone else.

Comment 5

[qasim]

I'd love to work on this bug.

Comment 6

[qasim]

Attachment: The .diff file for a working patch to this bug.

[Security approval request comment]
How easily could an exploit be constructed based on the patch?

Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?

Which older supported branches are affected by this flaw?

If not all supported branches, which bug introduced the flaw?

Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?

How likely is this patch to cause regressions; how much testing does it need?

Would love if you could take a look at this. I think this is what you were looking for!

Comment 7

[Al Billings [:abillings - ex-MoCo]]

Comment on attachment 8561666 [details] [diff] [review]
The .diff file for a working patch to this bug.

Clearing sec-approval flag as this isn't a security issue.

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8561666 [details] [diff] [review]
The .diff file for a working patch to this bug.

Thanks for the patch - have you built and verified that this works?

Comment 9

[qasim]

(In reply to Chenxia Liu [:liuche] from comment #8)
> Comment on attachment 8561666 [details] [diff] [review]
> The .diff file for a potential patch to this bug.
> 
> Thanks for the patch - have you built and verified that this works?

Hi, I submitted this patch under supervision at Mozilla offices in Toronto. I wasn't able to built and test the feature, but was told I could forward it to some sort of testing facility. Would love more help on that subject! :)

Comment 10

[Chenxia Liu [:liuche]]

We really expect contributors to at least be able to build and verify their patches locally. One of the main points of these [good first bug]s is to help contributors get their build environment set up by fixing a simple bug, so in the future, they'll have that environment

I think your supervisor at Toronto meant that you didn't need to run *all* the tests locally, but you really do need to be able to build locally. Who is that, by the way? I think I need to have a chat with them :P

Take a look at https://wiki.mozilla.org/Mobile/Fennec/Android for our tutorial on getting set up. Let me know if you run into problems, or drop into #mobile for help!

Comment 11

[qasim]

(In reply to Chenxia Liu [:liuche] from comment #10)
> We really expect contributors to at least be able to build and verify their
> patches locally. One of the main points of these [good first bug]s is to
> help contributors get their build environment set up by fixing a simple bug,
> so in the future, they'll have that environment
> 
> I think your supervisor at Toronto meant that you didn't need to run *all*
> the tests locally, but you really do need to be able to build locally. Who
> is that, by the way? I think I need to have a chat with them :P
> 
> Take a look at https://wiki.mozilla.org/Mobile/Fennec/Android for our
> tutorial on getting set up. Let me know if you run into problems, or drop
> into #mobile for help!

I won't mention names, but they walked me through the whole process and didn't mention that. Thanks for letting me know, though!

Comment 12

[Bhargav Chippada [:bhargavch]]

Hi, i would love to work on this bug. I have set up my build environment. I have a doubt, is my gecko-dev (--depth=1 only) repository need to be up-to-date everyday or i can just work on the bug and submit a patch? if i want to up-to-date my local repository, is there a way to safely merge the changes and build only the parts that changed?

Thanks.
Now i will get going on my first bug.

Comment 13

[Bhargav Chippada [:bhargavch]]

Attachment: working patch for using case-insensitive search in about:passwords

Hi, please assign me to this bug. I have tested the patch and its working.

Comment 14

[qasim]

(In reply to Bhargav Chippada from comment #13)
> Created attachment 8570023 [details] [diff] [review]
> working patch for using case-insensitive search in about:passwords
> 
> Hi, please assign me to this bug. I have tested the patch and its working.

I did too, tested and everything, a couple weeks ago. I don't think they are assigning people to bug and just getting multiple people to complete it to get an idea of how to submit bugs.

Comment 15

[Chenxia Liu [:liuche]]

Oh no, sorry for the confusion, we do want this bug fixed! I was unaware that qasim, you had ended up building and testing the bug already. I wanted to make sure that you were able to get a build made with the patch applied, but now that you've done that, let me review it. Thanks!

Comment 16

[Chenxia Liu [:liuche]]

I built and tested this, so I'll land it. One thing - the commit message should list the bug number and description and reviewer, e.g.:

Bug 1123431 - Use case-insensitive search for filtering passwords on about:passwords. r=liuche

I'll fix that when I land this though.

Comment 17

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/ab9ddccfc5c7

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab9ddccfc5c7