1123580 - [Telephony] Reorganize mmi parsing related code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

Just want to reorganize the code to make it clearer.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Reorganize mmi parsing related code

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8551664 [details] [diff] [review]
Reorganize mmi parsing related code

Review of attachment 8551664 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: #2 Reorganize mmi parsing related code

There is a flaw in previous version. gMMIParser refers to isEmergencyNumber() which is still under TelephonyService.

I am thinking about doing it more by extracting them into DialNumberUtils.jsm which provides abilities to check and parse the dial number.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8552297 [details] [diff] [review]
#2 Reorganize mmi parsing related code

Review of attachment 8552297 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=me with comment addressed, thank you.

::: dom/telephony/gonk/DialNumberUtils.jsm
@@ +7,5 @@
> +this.EXPORTED_SYMBOLS = ["DialNumberUtils"];
> +
> +const {classes: Cc, interfaces: Ci, utils: Cu, results: Cr} = Components;
> +
> +Cu.import("resource://gre/modules/XPCOMUtils.jsm");

This should be safe to remove.

::: dom/telephony/gonk/TelephonyService.js
@@ +81,5 @@
>    Cu.import("resource://gre/modules/PhoneNumberUtils.jsm", ns);
>    return ns.PhoneNumberUtils;
>  });
>  
> +XPCOMUtils.defineLazyGetter(this, "gDialNumberUtils", function() {

With gDialNumberUtils, we don't need [1] anymore. Please help remove it.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyService.js?from=TelephonyService.js#13

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=50ef1f3276b9

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/755c92298a53

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/755c92298a53