1123732 - crash in mozilla::net::HttpBaseChannel::SetupReplacementChannel(nsIURI*, nsIChannel*, bool), Enhanced Steam add-on

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[Honza Bambas (:mayhemer)]

This bug was filed from the Socorro interface and is 
report bp-9d80d0be-f2ad-4e13-9060-3b7662150113.
=============================================================

Some DOM codepaths allow creation of requests having principals with null URLs.  The logging code doesn't check presence of the URL when listing redirects.  Redirects are combined from channel's principal URLs.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Honza, thanks for the super fast answer in the other bug.
Could you fill the uplift request for aurora, beta & release? Thanks

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07dd454814b9

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07dd454814b9

Comment 5

[Honza Bambas (:mayhemer)]

Comment on attachment 8551851 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: 974018
[User impact if declined]: null deref crash
[Describe test coverage new/current, TreeHerder]: landed on m-c a day ago
[Risks and why]: zero, just bypasses nsAutoCString assignment when an object to call a method to fill it is found null
[String/UUID change made/needed]: none

Comment 6

[Honza Bambas (:mayhemer)]

(In reply to Honza Bambas (:mayhemer) from comment #5)
> [Risks and why]: zero, just bypasses nsAutoCString assignment when an object
> to call a method to fill it is found null

And it's just for NSPR logging purposes!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c9bfddb928fc
https://hg.mozilla.org/releases/mozilla-beta/rev/3096b7b44265
https://hg.mozilla.org/releases/mozilla-release/rev/f19bf2ab3d14

Comment 8

[Cornel Ionce [:noni] [Hubs QA]]

The crash rate decreased a lot.
In the last week there were:
- 0 crashes for Firefox 35.0.1 (down from 361 crashes in Firefox 35.0)
- On the beta channel, there were 2 crashes on 36.0b2 and none for 36.0b4 and 36.0b5
- 2 crashes on 37.0a2.
- No crashes on Nightly 38.

Based on these results, I consider it's safe to mark this issue verified.
Please reopen if you disagree. Thanks!

Comment 10

[mkdante381]

Crash on http://steamcommunity.com/market/ with Enhanced Steam 7.3
Crash Report https://crash-stats.mozilla.com/report/index/8a6dca85-a1ff-4cec-9a89-8ace72150316