Closed Bug 1123732 Opened 6 years ago Closed 6 years ago
crash in mozilla::net::Http
Base Channel::Setup Replacement Channel(ns IURI*, ns IChannel*, bool), Enhanced Steam add-on
This bug was filed from the Socorro interface and is report bp-9d80d0be-f2ad-4e13-9060-3b7662150113. ============================================================= Some DOM codepaths allow creation of requests having principals with null URLs. The logging code doesn't check presence of the URL when listing redirects. Redirects are combined from channel's principal URLs.
Attachment #8551851 - Flags: review?(mcmanus) → review+
Honza, thanks for the super fast answer in the other bug. Could you fill the uplift request for aurora, beta & release? Thanks
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8551851 [details] [diff] [review] v1 Approval Request Comment [Feature/regressing bug #]: 974018 [User impact if declined]: null deref crash [Describe test coverage new/current, TreeHerder]: landed on m-c a day ago [Risks and why]: zero, just bypasses nsAutoCString assignment when an object to call a method to fill it is found null [String/UUID change made/needed]: none
Attachment #8551851 - Flags: approval-mozilla-release?
Attachment #8551851 - Flags: approval-mozilla-release+
Attachment #8551851 - Flags: approval-mozilla-beta?
Attachment #8551851 - Flags: approval-mozilla-beta+
Attachment #8551851 - Flags: approval-mozilla-aurora?
Attachment #8551851 - Flags: approval-mozilla-aurora+
(In reply to Honza Bambas (:mayhemer) from comment #5) > [Risks and why]: zero, just bypasses nsAutoCString assignment when an object > to call a method to fill it is found null And it's just for NSPR logging purposes!
The crash rate decreased a lot. In the last week there were: - 0 crashes for Firefox 35.0.1 (down from 361 crashes in Firefox 35.0) - On the beta channel, there were 2 crashes on 36.0b2 and none for 36.0b4 and 36.0b5 - 2 crashes on 37.0a2. - No crashes on Nightly 38. Based on these results, I consider it's safe to mark this issue verified. Please reopen if you disagree. Thanks!
Crash on http://steamcommunity.com/market/ with Enhanced Steam 7.3 Crash Report https://crash-stats.mozilla.com/report/index/8a6dca85-a1ff-4cec-9a89-8ace72150316
You need to log in before you can comment on or make changes to this bug.