Closed Bug 1123734 Opened 10 years ago Closed 10 years ago

Notify global VsyncSource in hwc

Categories

(Core Graveyard :: Widget: Gonk, defect)

Product:
Core Graveyard
Component:
Widget: Gonk
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: jerry, Assigned: jerry)

References

Details

Attachments

(1 file)

Notify global VsyncSource in hwc. v1
3.29 KB, patch
mwu
: review+
mchang
: review+
bajaj
: approval-mozilla-b2g37+
Details | Diff | Splinter Review
Currently, hwc only notify the CompositorVsyncDispatcher in widget[1][2]. RefreshDriverVsyncDispatcher will not be ticked. I would like to tick the global vsync source instead of CompositorVsyncDispatcher. [1] https://hg.mozilla.org/mozilla-central/file/c2df1daf74c3/widget/gonk/HwcComposer2D.cpp#l231 [2] https://hg.mozilla.org/mozilla-central/file/c2df1daf74c3/widget/gonk/nsWindow.cpp#l225
Attachment #8551848 - Flags: review?(bugmail.mozilla)
Comment on attachment 8551848 [details] [diff] [review] Notify global VsyncSource in hwc. v1 Review of attachment 8551848 [details] [diff] [review]: ----------------------------------------------------------------- Looks ok to me but I think other people should review this.
Attachment #8551848 - Flags: review?(mwu)
Attachment #8551848 - Flags: review?(mchang)
Attachment #8551848 - Flags: review?(bugmail.mozilla)
Comment on attachment 8551848 [details] [diff] [review] Notify global VsyncSource in hwc. v1 Review of attachment 8551848 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #8551848 - Flags: review?(mchang) → review+
Blocks: 1123762
Attachment #8551848 - Flags: review?(mwu) → review+
please land the attachment 8551848 [details] [diff] [review] to m-c.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Hi Jerry, could you provide a try run for this change? Thanks!
Flags: needinfo?(hshih)
Keywords: checkin-needed
This patch is only related to gonk. Just try b2g parts. https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f5363b15725 Will request checkin-needed later.
Flags: needinfo?(hshih)
https://hg.mozilla.org/mozilla-central/rev/8509475adf12
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8551848 [details] [diff] [review] Notify global VsyncSource in hwc. v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): none User impact if declined: a part of silk, bug 987532. Testing completed: landed in m-c. m-c try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f5363b15725 Risk to taking this patch (and alternatives if risky): small, we don't turn on the silk pref by default. String or UUID changes made by this patch: none
Attachment #8551848 - Flags: approval-mozilla-b2g37?
Attachment #8551848 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: