1123734 - Notify global VsyncSource in hwc

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Currently, hwc only notify the CompositorVsyncDispatcher in widget[1][2]. RefreshDriverVsyncDispatcher will not be ticked.

I would like to tick the global vsync source instead of CompositorVsyncDispatcher.

[1] 
https://hg.mozilla.org/mozilla-central/file/c2df1daf74c3/widget/gonk/HwcComposer2D.cpp#l231
[2]
https://hg.mozilla.org/mozilla-central/file/c2df1daf74c3/widget/gonk/nsWindow.cpp#l225

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Notify global VsyncSource in hwc. v1

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8551848 [details] [diff] [review]
Notify global VsyncSource in hwc. v1

Review of attachment 8551848 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me but I think other people should review this.

Comment 3

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8551848 [details] [diff] [review]
Notify global VsyncSource in hwc. v1

Review of attachment 8551848 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

please land the attachment 8551848 [details] [diff] [review] to m-c.

Comment 5

[Carsten Book [:Tomcat]]

Hi Jerry, could you provide a try run for this change? Thanks!

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

This patch is only related to gonk. Just try b2g parts.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f5363b15725

Will request checkin-needed later.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8509475adf12

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8509475adf12

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8551848 [details] [diff] [review]
Notify global VsyncSource in hwc. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: a part of silk, bug 987532.
Testing completed:
landed in m-c. m-c try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f5363b15725
Risk to taking this patch (and alternatives if risky): small, we don't turn on the silk pref by default.
String or UUID changes made by this patch: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/69d8f3207335