1123809 - Record history as visits

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Wesley Johnston (:wesj)]

We want to record history visits individually on iOS. Probably with a date, and a transition type (i.e. did you click a link, type the url, was this a redirect, etc)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Pull request

Asking for feedback/review (i.e. you pick! :) )

Comment 2

[Richard Newman [:rnewman]]

Attachment: Pull request. v2

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8556099 [details] [review]
Pull request. v2

Comments left on pull req; needs one more iteration on the visits schema, I think.

Please file a follow-up to think about expiration!

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8556099 [details] [review]
Pull request. v2

Updated the PR. Using int for site ids. I'm not sure the best way to handle dates here, so I'm happy to get advice. NSTimerInterval's on iOS are doubles (in units of seconds), so that's what I'm storing now. There are plenty of other options if you want something different...

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8556099 [details] [review]
Pull request. v2

This looks good. My only big question is if we should turn the FavIcon detection into a UserScript and a BrowserHelper. (ReaderMode is a good example of something that runs on every page). I think that will speed things up since the script will be in the webview, ready to go, and it will also make the messaging nicer.

Comment 6

[Wesley Johnston (:wesj)]

Argh. I was trying to remove the favicon code from this. It should be a separate PR I think. But if it slips in here and we're happy, I'm not going to force another review :)

I also added an explicit ID column to the visits table now (but no guids!). I think at somepoint it would be nice to track a session of visits: Site A -> Site B -> Site C. We'll need IDs for something like that. Best to do it now I guess.

Comment 7

[Wesley Johnston (:wesj)]

I landed this. Lets use follow ups for any cleanup we need.