1123871 - Port locationBar specific library features from mozmill-tests

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

This will allow conversion of the awesomeBar tests, and will at least involve conversion of the NavBar and LocationBar classes from:

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/lib/toolbars.js

Comment 1

[Chris Manchester (limited bugmail, email directly)]

I have a good portion of this working on a local branch: https://github.com/chmanchester/firefox-ui-tests/tree/locationbar

I'm going to clean this up a bit and then we may want to land as much as I have so far.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Note: The portions of toolbars.js not covered by this pull request will be the "edit bookmarks" panel, the downloads panel, and the menu panel.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Implement navbar, locationbar, and autocompleteresults in firefox puppetteer

I need to make sure this plays well with readthedocs, but that doesn't need to block code review.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

:whimboo offered to help me figure out what's causing this PR to fail in travis (it works consistently for me locally). I'm really not sure what's going wrong here.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

:whimboo helped me with this just now. I guess these sorts of tests were failing when Mozmill was run in travis, as well, and I can reproduce the exact failure running under xvfb locally, so my conclusion for the moment is that the autocomplete popup fails to open without a real display. This may well be a Firefox front-end bug, but given that the tests run well locally, and this was a problem with Mozmill as well, we agreed to skip these in Travis for now.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8554841 [details] [review]
Implement navbar, locationbar, and autocompleteresults in firefox puppetteer

I'm going to clean up the branch and get failing tests skipped before re-requesting review.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8554841 [details] [review]
Implement navbar, locationbar, and autocompleteresults in firefox puppetteer

Ok, the skipping facility works fine. I reverted all my troubleshooting commits.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8554841 [details] [review]
Implement navbar, locationbar, and autocompleteresults in firefox puppetteer

This implementation looks great! Thanks Chris! I added a bunch of comments, so please go through them. Lets know on the PR if there are problems or questions.

I will move this to feedback, given that for review I wanna see those items fixed.

Comment 9

[Chris Manchester (limited bugmail, email directly)]

(In reply to Henrik Skupin (:whimboo) from comment #8)
> Comment on attachment 8554841 [details] [review]
> Implement navbar, locationbar, and autocompleteresults in firefox puppetteer
> 
> This implementation looks great! Thanks Chris! I added a bunch of comments,
> so please go through them. Lets know on the PR if there are problems or
> questions.
> 
> I will move this to feedback, given that for review I wanna see those items
> fixed.

Thanks for the thorough review. I've added a few comments/questions to the PR, I'll push a fixup and re-request shortly.

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8554841 [details] [review]
Implement navbar, locationbar, and autocompleteresults in firefox puppetteer

Ok, this has review comments addressed except in cases I have questions/comments pending.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8554841 [details] [review]
Implement navbar, locationbar, and autocompleteresults in firefox puppetteer

There is one TODO comment to be added. Otherwise the PR looks fine to me. Thank you Chris!

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please don't forget to close bugs! :)

This PR landed as:
https://github.com/mozilla/firefox-ui-tests/commit/379d34bd7087b61c6d767e22687a078aef250cab