1123875 - Setting a readonly attribute on a proxy no longer throws in strict mode.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Test

I suspect because bug 1103368 didn't update DOMProxyHandler::defineProperty. I confirmed that it still worked in the Fx34.0 release and didn't work in a 37 build from last week or so.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

[Tracking Requested - why for this release]:

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

jorendorff and ms2ger confirmed via irc that this is a small issue. We're simply not throwing an exception in one case where we should. As such, I don't think this warrants tracking. I'm happy to consider an uplift request.

Comment 3

[Jason Orendorff [:jorendorff]]

This is fixed, and I did a *ton* of work on SetProperty paths so I imagine that fixed it at some point.

We should have a test for this, so I'm leaving it open and taking.

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Add a test for strict assignment to a readonly WebIDL attribute

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Use a testharness.js mochitest with assert_throws(new TypeError(), function() { .. }) to reduce boilerplate.

Comment 6

[Jason Orendorff [:jorendorff]]

Thanks for the nudge. That's a big difference. Building now to retest.

Comment 7

[Jason Orendorff [:jorendorff]]

Attachment: Add a test for strict assignment to a readonly WebIDL attribute

Comment 8

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06dbe25231c2

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out (along with every other patch from that massive push) in https://hg.mozilla.org/integration/mozilla-inbound/rev/386c8b5b73c0 for talos other timeouts:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3fc49391f7fe&filter-searchStr=talos oth

Comment 10

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e245cf4f340

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e245cf4f340