1123923 - Firefox crash in mozilla::MediaPromise<nsRefPtr<mozilla::AudioData>, mozilla::MediaDecoderReader::NotDecodedReason>::Resolve(nsRefPtr<mozilla::AudioData>, char const*)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-c24ba66e-aaa9-4d5d-ac74-2bbd82150120.
=============================================================

Small volume crash seen while looking at crash stats. Link to all crashes: https://crash-stats.mozilla.com/report/list?product=Firefox&signature=mozilla::MediaPromise%3CnsRefPtr%3Cmozilla::AudioData%3E,%20mozilla::MediaDecoderReader::NotDecodedReason%3E::Resolve%28nsRefPtr%3Cmozilla::AudioData%3E,%20char%20const*%29

Sample youtube URLs:

3 	https://www.youtube.com/watch?v=iTIO-Ci15fA
2 	https://www.youtube.com/watch?v=Oa3Xx-8xCGQ
1 	https://www.youtube.com/watch?v=mpi0qsp3v_w
1 	https://www.youtube.com/watch?v=Xg0K07QZTXw
1 	https://www.youtube.com/user/YouNeedABudget
1 	https://www.youtube.com/watch?v=PL1MgcKq1FU
1 	http://www.youtube.com/watch?v=1b6j6JhtwcA&list=PLT91BLBbPSDMbLUWFbPd3Qlkw2UtaVwb_&index=14
1 	https://www.youtube.com/watch?v=hRm-BSukPds
1 	www.youtube.com
1 	https://ssyoutube.com/watch?v=hMnqmBsms_M&spfreload=10
1 	https://www.youtube.com/watch?v=Sv2-tENiwIw

Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::MediaPromise<nsRefPtr<mozilla::AudioData>, mozilla::MediaDecoderReader::NotDecodedReason>::Resolve(nsRefPtr<mozilla::AudioData>, char const*) 	dom/media/MediaPromise.h
1 	xul.dll 	mozilla::MediaPromiseHolder<mozilla::MediaPromise<nsRefPtr<mozilla::AudioData>, mozilla::MediaDecoderReader::NotDecodedReason> >::Resolve(nsRefPtr<mozilla::AudioData>, char const*) 	dom/media/MediaPromise.h
2 	xul.dll 	mozilla::MediaSourceReader::OnVideoDecoded(mozilla::VideoData*) 	dom/media/mediasource/MediaSourceReader.cpp
3 	xul.dll 	mozilla::MediaPromise<nsRefPtr<mozilla::AudioData>, mozilla::MediaDecoderReader::NotDecodedReason>::ThenValue<mozilla::MediaTaskQueue, mozilla::MediaDecodeTask, void ( mozilla::MediaDecodeTask::*)(mozilla::AudioData*), void ( mozilla::MediaDecodeTask::*)(mozilla::MediaDecoderReader::NotDecodedReason)>::DoResolve(nsRefPtr<mozilla::AudioData>) 	dom/media/MediaPromise.h
4 	xul.dll 	mozilla::MediaPromise<nsRefPtr<mozilla::AudioData>, mozilla::MediaDecoderReader::NotDecodedReason>::ThenValueBase::ResolveRunnable::Run() 	dom/media/MediaPromise.h
5 	xul.dll 	mozilla::MediaTaskQueue::Runner::Run() 	dom/media/MediaTaskQueue.cpp
6 	xul.dll 	nsThreadPool::Run() 	xpcom/threads/nsThreadPool.cpp
7 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp
8 	xul.dll 	NS_ProcessNextEvent(nsIThread*, bool) 	xpcom/glue/nsThreadUtils.cpp
9 	xul.dll 	mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp
10 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc
11 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc
12 	xul.dll 	nsThread::ThreadFunc(void*) 	xpcom/threads/nsThread.cpp
13 	nss3.dll 	_PR_NativeRunThread 	nsprpub/pr/src/threads/combined/pruthr.c
14 	nss3.dll 	pr_root 	nsprpub/pr/src/md/windows/w95thred.c
15 	msvcr120.dll 	_callthreadstartex 	f:\dd\vctools\crt\crtw32\startup\threadex.c:376
16 	msvcr120.dll 	msvcr120.dll@0x2c000 	
17 	kernel32.dll 	BaseThreadInitThunk 	
18 	ntdll.dll 	__RtlUserThreadStart 	
19 	ntdll.dll 	_RtlUserThreadStart

Comment 1

[Marcia Knous [:marcia]]

Added two more similar signatures that seem to be showing up as well.

Comment 2

[Bobby Holley (:bholley)]

I've got a theory - will file a dependent bug.

Comment 3

[Marcia Knous [:marcia]]

@ mozilla::MediaPromiseHolder<mozilla::MediaPromise<nsRefPtr<mozilla::AudioData>, mozilla::MediaDecoderReader::NotDecodedReason>>::Resolve(nsRefPtr<mozilla::AudioData>,char const*)

showed up in today's explosive report in beta: https://crash-analysis.mozilla.com/rkaiser/2015-01-22/2015-01-22.firefox.36.explosiveness.html

Comment 4

[Bobby Holley (:bholley)]

Can you tell if bug 1123983 removed/reduced this crash on Nightly? Or is it too soon to say?

Comment 5

[Marcia Knous [:marcia]]

(In reply to Bobby Holley (Busy with media, don't ask for DOM/JS/XPConnect things) from comment #4)
> Can you tell if bug 1123983 removed/reduced this crash on Nightly? Or is it
> too soon to say?

I think it is still too early. Will look at tomorrow's data. I will keep ni on myself to follow up.

Comment 6

[Marcia Knous [:marcia]]

Another explosive crash showed up in nightly with the Media Promise signature: http://bit.ly/1EmZxxv. A review of the URLs show all youtube.com.

Comment 7

[Bobby Holley (:bholley)]

(In reply to Marcia Knous [:marcia - use needinfo] from comment #6)
> Another explosive crash showed up in nightly with the Media Promise
> signature: http://bit.ly/1EmZxxv. A review of the URLs show all youtube.com.

The first crash I looked at is crashing here: hg.mozilla.org/mozilla-central/annotate/494632b9afed/dom/media/MediaPromise.h#l248

Which is the release-mode assertion that I added in bug 1123983. That assertion isn't being backported to beta, which is good. And jya managed to reproduce the assertion failure in bug 1124952, which I'm going to look at today.

Comment 8

[Bobby Holley (:bholley)]

Now that bug 1124952 has landed, flagging marcia to see if this crash finally goes away.

Comment 9

[Marcia Knous [:marcia]]

(In reply to Bobby Holley (Busy with media, don't ask for DOM/JS/XPConnect things) from comment #8)
> Now that bug 1124952 has landed, flagging marcia to see if this crash
> finally goes away.

bholley: You are right - http://bit.ly/1uGNxP1 shows no MediaPromise crashes after 20150127030230 build on nightly.

Comment 10

[Bobby Holley (:bholley)]

Great!