1124019 - (keep monitoring) Ensure Facebook import still works after SDK v1.0 is turned off

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1060743 +++

While FQL will still be available for SDK v2.0 (which prolong the deadline of bug 1060743), the SDK v1.0 itself will still be turned off by Apr 30, 2015.

I don't know if all the API calls we are using involve 0 schema change (my experience told me the permission part has already changed), therefore it's desirable if we could test ourselves first.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: let's not block on it as it's not an issue yet.

Jose, would you like to comment on this?
What would happen after SDK v1.0 turned off.

Comment 2

[Jose Manuel Cantera]

We are using FQL and FQL will remain in v2.0 SDK. So to the best of my knowledge I think we do not need to make any change. 
However, I would like to double-check it with the Facebook technical people just to make sure I have interpreted correctly their documentation or there is anything I could have missed.

Francisco, Wesley I think our contact person with Facebook is Harald, can we forward to him the question? I can write the email for FB if necessary.

Thanks!

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Per the doc it says FQL is supported in 2.0SDK.
https://developers.facebook.com/docs/apps/upgrading#upgrading_v2_0_fql

Harald,
Can you please reconfirm with Facebook? (I assume you have connection with them)

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please read comment 0. This bug is cloned and explicitly for the purpose of making sure we do not break when SDK v1.0 is turned off, on Apr 30, 2015. The FQL availability issue is always covered by bug 1060743. Please stop talking about FQL here.

We simply need to confirm that the app works with SDK v2.0 and our permission bits is correctly set, and there are no action items on our side for this migration (e.g. submit for Login Reviews).

Comment 5

[:Harald Kirschner :digitarald]

Didem mentioned in the past that Francisco got introduced to the responsible person at Facebook. ni? on Didem as she might be able to re-introduce.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Will wait for Didem support to have a technical talk with FB engineers.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: we need to assure this won't become an issue

Comment 8

[Didem Ersoz [:didem]]

Francisco,

What can we send to Facebook to confirm the change from sdk 1.0 to 2.0 will not break the implementation in FxOS? Do we have any unit tests? Have you had a chance to test how the FxOS devices with sdk 1.0 implemented handles sdk 2.0?

Thanks,
Didem

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I am getting the following automated message from Facebook:

====

Your app, Firefox OS, is making calls to v1.0 of the Graph API which will be deprecated on Thursday, April 30, 2015. Please upgrade your app to v2.0 or later by that date. The following API requests from your app may be affected.

DEPRECATIONS

    The 'username' field on the user object has been removed.
    All friend permissions ('friends_photos', 'friends_birthday', etc) have been removed. Friend data is no longer available.
    The 'export_stream' permission is no longer available.

CHANGED BEHAVIORS

    When using a user access token and querying other users, non-friends behave as if they have not installed the application unless the `appsecret_proof` is provided
    (May affect 88.91% of your app's v1.0 API calls)
        GET user/picture
    The fields 'bio', 'education', 'hometown', 'likes', 'location', 'political', 'religion' and 'work' on the user object are now only available with the explicit permissions 'user_about_me', 'user_education_history', 'user_hometown', 'user_likes', 'user_location', 'user_religion_politics' and 'user_work_history' respectively.
    (May affect 88.91% of your app's v1.0 API calls)
        GET user/picture

Please read the full changelog here and ensure your app is fully migrated.
You can view this and other Developer Notifications related to your app, Firefox OS, in the App Dashboard.
Thanks,
The Facebook Team

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Didem,

can we setup a meeting with FB engineering team for next week? I think that will be easier than going back and forward with emails.

Jose can you attend that meeting too?

Comment 11

[Jose Manuel Cantera]

Yes, I can

Comment 12

[Didem Ersoz [:didem]]

Hi Francisco, I've just sent an email and re-connected you with the Facebook Partner engineer David Lim. Feel free to work out a time that works for both of you. (If I remember it right, he was based somewhere in Asia, probably Hong Kong)

Please keep me in the email loop. But since I am based in the US, my time zone will probably not work with you two.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Hi Didem,

thanks a lot, I'm just going through our current implementation to refresh all the stuff we have and prepare some tests.

Thanks again!

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Just for people watching this bug:
We are impacted by the v2.0 api change, as we are not able to get the whole list of contacts, just those friends that already have the app. Seems that this deep integration is not very usable. Talking to FB to see how we can fix this.

Comment 15

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #14)
> Just for people watching this bug:
> We are impacted by the v2.0 api change, as we are not able to get the whole
> list of contacts, just those friends that already have the app. Seems that
> this deep integration is not very usable. Talking to FB to see how we can
> fix this.

That would be a very bad user experience. 
We're expecting to hear feedbacks from FB.

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

Just to add more information:

- FB patner engineering are in top of this, we are blocked waiting for their answer.

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

According to latest communication with FB, we won't be affected by this change, since they will white list our APP id to continue working.

We won't be whitelisted forever, now on BD land to deal on new agreement between the companies.

Wesley, should we unnominate it for 2.2?

Comment 18

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Yes. Then it's not a blocker at this moment. Putting 2.2? and let's further confirm in the triage.

Comment 19

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: per comment 17 and comment 18, let's unblock it.

If in the future we're no longer whitelisted, we would like to get informed in advance.
Leave this tracking in backlog.

Comment 20

[BMO Automation]

Firefox OS is not being worked on