Closed Bug 1124052 Opened 5 years ago Closed 5 years ago

Preprocess less in Android Background Services

Categories

(Android Background Services Graveyard :: Build & Test, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 38

People

(Reporter: nalexander, Assigned: nalexander)

Details

Attachments

(4 files, 1 obsolete file)

Right now, we preprocess:

src/main/java/org/mozilla/gecko/background/common/GlobalConstants.java.in
src/main/java/org/mozilla/gecko/background/healthreport/HealthReportConstants.java.in
src/main/java/org/mozilla/gecko/fxa/FxAccountConstants.java.in
src/main/java/org/mozilla/gecko/sync/SyncConstants.java.in

We can make a few things around and then depend on AppConstants.java.in.  Just a little simpler, fewer moving pieces; and it will simplify fennec-copy-code.sh.
rnewman: quick second set of eyes?
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8552596 - Flags: review?(rnewman)
/r/2817 - Bug 1124052 - Part 0: Don't preprocess SysInfo. r=rnewman
/r/2819 - Bug 1124052 - Part 1: Remove BUILD_TIMESTAMP_*. r=rnewman
/r/2821 - Bug 1124052 - Part 2: Don't preprocess Java in background services. r=rnewman

Pull down these commits:

hg pull review -r 39a62c9d62e75b2a7591cc4707703a8522505cf3
Comment on attachment 8552598 [details]
MozReview Request: bz://1124052/nalexander

/r/2817 - Bug 1124052 - Part 0: Don't preprocess SysInfo. r=rnewman
/r/2819 - Bug 1124052 - Part 1: Remove BUILD_TIMESTAMP_*. r=rnewman
/r/2821 - Bug 1124052 - Part 2: Don't preprocess Java in background services. r=rnewman

Pull down these commits:

hg pull review -r 39a62c9d62e75b2a7591cc4707703a8522505cf3
Attachment #8552598 - Flags: review?(rnewman)
Comment on attachment 8552598 [details]
MozReview Request: bz://1124052/nalexander

https://reviewboard.mozilla.org/r/2815/#review2013

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String ACCOUNT_DELETED_ACTION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.accounts.ACCOUNT_DELETED_ACTION";

I think you missed one.

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String PER_ACCOUNT_TYPE_PERMISSION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.permission.PER_ACCOUNT_TYPE";

Two.

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String ACCOUNT_STATE_CHANGED_ACTION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.accounts.ACCOUNT_STATE_CHANGED_ACTION";

Three.
Attachment #8552598 - Flags: review?(rnewman)
Attachment #8552596 - Flags: review?(rnewman) → review+
You need to log in before you can comment on or make changes to this bug.