1124052 - Preprocess less in Android Background Services

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Build & Test, defect)

Description

[Nick Alexander :nalexander [he/him]]

Right now, we preprocess:

src/main/java/org/mozilla/gecko/background/common/GlobalConstants.java.in
src/main/java/org/mozilla/gecko/background/healthreport/HealthReportConstants.java.in
src/main/java/org/mozilla/gecko/fxa/FxAccountConstants.java.in
src/main/java/org/mozilla/gecko/sync/SyncConstants.java.in

We can make a few things around and then depend on AppConstants.java.in.  Just a little simpler, fewer moving pieces; and it will simplify fennec-copy-code.sh.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/526

rnewman: quick second set of eyes?

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: bz://1124052/nalexander

/r/2817 - Bug 1124052 - Part 0: Don't preprocess SysInfo. r=rnewman
/r/2819 - Bug 1124052 - Part 1: Remove BUILD_TIMESTAMP_*. r=rnewman
/r/2821 - Bug 1124052 - Part 2: Don't preprocess Java in background services. r=rnewman

Pull down these commits:

hg pull review -r 39a62c9d62e75b2a7591cc4707703a8522505cf3

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8552598 [details]
MozReview Request: bz://1124052/nalexander

/r/2817 - Bug 1124052 - Part 0: Don't preprocess SysInfo. r=rnewman
/r/2819 - Bug 1124052 - Part 1: Remove BUILD_TIMESTAMP_*. r=rnewman
/r/2821 - Bug 1124052 - Part 2: Don't preprocess Java in background services. r=rnewman

Pull down these commits:

hg pull review -r 39a62c9d62e75b2a7591cc4707703a8522505cf3

Comment 4

[Nick Alexander :nalexander [he/him]]

https://tbpl.mozilla.org/?tree=Try&rev=0c01fa549b06

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8552598 [details]
MozReview Request: bz://1124052/nalexander

https://reviewboard.mozilla.org/r/2815/#review2013

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String ACCOUNT_DELETED_ACTION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.accounts.ACCOUNT_DELETED_ACTION";

I think you missed one.

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String PER_ACCOUNT_TYPE_PERMISSION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.permission.PER_ACCOUNT_TYPE";

Two.

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String ACCOUNT_STATE_CHANGED_ACTION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.accounts.ACCOUNT_STATE_CHANGED_ACTION";

Three.

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/40385ec275b7
https://hg.mozilla.org/integration/fx-team/rev/0ebf567bee4b
https://hg.mozilla.org/integration/fx-team/rev/fad1207a0a99

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/40385ec275b7
https://hg.mozilla.org/mozilla-central/rev/0ebf567bee4b
https://hg.mozilla.org/mozilla-central/rev/fad1207a0a99

Comment 9

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1124052 - Part 0: Don't preprocess SysInfo. r=rnewman

Comment 10

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1124052 - Part 1: Remove BUILD_TIMESTAMP_*. r=rnewman

Comment 11

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1124052 - Part 2: Don't preprocess Java in background services. r=rnewman