Preprocess less in Android Background Services

RESOLVED FIXED in Firefox 38

Status

Android Background Services
Build & Test
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

unspecified
Firefox 38
All
Android

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Right now, we preprocess:

src/main/java/org/mozilla/gecko/background/common/GlobalConstants.java.in
src/main/java/org/mozilla/gecko/background/healthreport/HealthReportConstants.java.in
src/main/java/org/mozilla/gecko/fxa/FxAccountConstants.java.in
src/main/java/org/mozilla/gecko/sync/SyncConstants.java.in

We can make a few things around and then depend on AppConstants.java.in.  Just a little simpler, fewer moving pieces; and it will simplify fennec-copy-code.sh.
(Assignee)

Comment 1

4 years ago
Created attachment 8552596 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/526

rnewman: quick second set of eyes?
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8552596 - Flags: review?(rnewman)
(Assignee)

Comment 2

4 years ago
Created attachment 8552598 [details]
MozReview Request: bz://1124052/nalexander

/r/2817 - Bug 1124052 - Part 0: Don't preprocess SysInfo. r=rnewman
/r/2819 - Bug 1124052 - Part 1: Remove BUILD_TIMESTAMP_*. r=rnewman
/r/2821 - Bug 1124052 - Part 2: Don't preprocess Java in background services. r=rnewman

Pull down these commits:

hg pull review -r 39a62c9d62e75b2a7591cc4707703a8522505cf3
(Assignee)

Comment 3

4 years ago
Comment on attachment 8552598 [details]
MozReview Request: bz://1124052/nalexander

/r/2817 - Bug 1124052 - Part 0: Don't preprocess SysInfo. r=rnewman
/r/2819 - Bug 1124052 - Part 1: Remove BUILD_TIMESTAMP_*. r=rnewman
/r/2821 - Bug 1124052 - Part 2: Don't preprocess Java in background services. r=rnewman

Pull down these commits:

hg pull review -r 39a62c9d62e75b2a7591cc4707703a8522505cf3
Attachment #8552598 - Flags: review?(rnewman)
Comment on attachment 8552598 [details]
MozReview Request: bz://1124052/nalexander

https://reviewboard.mozilla.org/r/2815/#review2013

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String ACCOUNT_DELETED_ACTION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.accounts.ACCOUNT_DELETED_ACTION";

I think you missed one.

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String PER_ACCOUNT_TYPE_PERMISSION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.permission.PER_ACCOUNT_TYPE";

Two.

::: mobile/android/base/fxa/FxAccountConstants.java
(Diff revision 1)
> +  public static final String ACCOUNT_STATE_CHANGED_ACTION = "@MOZ_ANDROID_SHARED_FXACCOUNT_TYPE@.accounts.ACCOUNT_STATE_CHANGED_ACTION";

Three.
Attachment #8552598 - Flags: review?(rnewman)
Attachment #8552596 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/40385ec275b7
https://hg.mozilla.org/mozilla-central/rev/0ebf567bee4b
https://hg.mozilla.org/mozilla-central/rev/fad1207a0a99
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
(Assignee)

Comment 8

3 years ago
Comment on attachment 8552598 [details]
MozReview Request: bz://1124052/nalexander
Attachment #8552598 - Attachment is obsolete: true
(Assignee)

Comment 9

3 years ago
Created attachment 8619186 [details]
MozReview Request: Bug 1124052 - Part 0: Don't preprocess SysInfo. r=rnewman
(Assignee)

Comment 10

3 years ago
Created attachment 8619187 [details]
MozReview Request: Bug 1124052 - Part 1: Remove BUILD_TIMESTAMP_*. r=rnewman
(Assignee)

Comment 11

3 years ago
Created attachment 8619188 [details]
MozReview Request: Bug 1124052 - Part 2: Don't preprocess Java in background services. r=rnewman
You need to log in before you can comment on or make changes to this bug.