1124105 - [RTL][Camera]"More info..." is covered by underline in App Permission view after launching camera in RTL language.

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Camera, defect, P3)

Description

[Norry.L.F(Leave from Mozilla)]

Attachment: 2015-01-21-16-40-04.png

[1.Description]:
[RTL][Camera]When it's the first time to launch camera, a "APP permission" view will display, and "More info..." is covered by underline in App Permission view after launch camera in RTL language.
Attached: 2015-01-21-16-40-04.png

[2.Testing Steps]: 
1. Set your phone to a RTL language (Arabic)  
2. Go to the Camera app for the first time.   
3. Observe the App Permission view

[3.Expected Result]: 
3.1 The text "More info..." should not be covered by underline.

[4.Actual Result]: 
3.1 The text "More info..." is covered by underline.

[5.Reproduction build]: 
Flame 2.2:
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118002501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150118.035516
FW-Date         Sun Jan 18 03:55:27 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Dylan Oliver [:doliver]]

Feels minor but Delphine will follow up with Ahmed on this one to judge severity.

Comment 2

[Dylan Oliver [:doliver]]

Confirmed P3.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] mpizza:Bug_1124105 > mozilla-b2g:master

Comment 4

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pr for master

Hi dmarcos,
   Could you help to review my patch and give me some feedback?
   Thanks.

Comment 5

[Diego Marcos [:dmarcos]]

This is a patch for the system app. Kevin might know who should review this.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8564913 [details] [review]
pr for master

It's better to use the autolander attachment.

Comment 7

[Kevin Grandon :kgrandon]

I don't understand the intent of this patch. Is the intent to just hide underline for arabic because it covers characters? Is it ok to use underlines and arabic together?

Ahmed - can you chime in with your experience with arabic and underline usage?

Comment 8

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Kevin Grandon :kgrandon from comment #7)
> I don't understand the intent of this patch. Is the intent to just hide
> underline for arabic because it covers characters? Is it ok to use
> underlines and arabic together?
> 
> Ahmed - can you chime in with your experience with arabic and underline
> usage?

Ok, so the original LTR spec has the more info underlined, so in a perfect world, that's how it should be in RTL too.

I looked at the text, and I can perfectly read it with absolutely no extra effort.
To be honest, we shouldn't be spending time on this one, because it is not a bug in the first place, Arabic users can read this and the line doesn't intervene with whether it is readable or not.
And yes Arabic does use underline in text as much as any other language and for the same purposes
I'm sorry Gary has spent his precious time on it but if I found this earlier I'd have marked it as invalid, because it is :)

Comment 9

[Kevin Grandon :kgrandon]

Ahmed - thank you very much for chiming in. I agree with your analysis and recommend that we close this as invalid.

Good to learn that Arabic & underlines are readable.