1124131 - [Loop] Loop call can't be established with URL shared between versions 1.1 and 1.1.1

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

Flame
2.0
Gecko-5f9dc54
Gaia-31d6c94
Loop version (1.1.1): master/51a04dd
Loop Version (1.1): d1417d1

Prerequisites:
Device A with Loop version 1.1. 
Device B with Loop version 1.1.1
Device A logged in  Mobile Loop application with MobileID.
Device B logged in  Mobile Loop application with FxA.
Contact C is saved with name and email.

STRs:
1. Device A taps on "Select contact" button in Loop application.
2. Device A selects contact C -> Loop call is dialing.
3. After a few seconds, "Share link" screen is shown, selects "Email" option and sends it. --> URL shared is shown in "Shared links" screen  in Device A.
4. In device B opens browser, email server and user taps on URL shared -> StandaloneUI is open.
5. In device B, user clicks on "Start" button. -> "Conversation" screen is shown in device B.
6. In device B, user clicks on "Call" button.

Actual result:
"Oops! That didn't work as expected. Why don't we give it another try?" message is shown.

Expected result:
Call is established.

Comment 1

[Maria Angeles Oteo (:oteo)]

One question Loli, are both applications pointing to the same server?

Comment 2

[Loli (:lolimartinezcr)]

(In reply to Maria Angeles Oteo (:oteo) from comment #1)
> One question Loli, are both applications pointing to the same server?

Both applications is point to the same server.

This is URL sent by 1.1 to 1.1.1:   https://loop-webapp-dev.stage.mozaws.net/c/1bjwlLx-NGU

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch

One line patch ...

In getCallUrl (client_request_helper.js) now we receive an object like [1] instead a token string.

[1] {"token":"h8FgO7daPAg","isVideoCall":true,"subject":""}

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8553091 [details] [review]
Proposed patch

LGTM, r=me with nits addressed.

Thanks for taking care of it Fernando.

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Nits addressed.
Landed - https://github.com/mozilla-b2g/firefoxos-loop-client/commit/dab4ccbddd2b4c53266b2a2593394c4934ec2d8b

Thank you