[Loop] Loop call can't be established with URL shared between versions 1.1 and 1.1.1

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: lolimartinezcr, Assigned: frsela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Room1.1.1_TestRun1][Room1.1.1_Exploratory1])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Flame
2.0
Gecko-5f9dc54
Gaia-31d6c94
Loop version (1.1.1): master/51a04dd
Loop Version (1.1): d1417d1

Prerequisites:
Device A with Loop version 1.1. 
Device B with Loop version 1.1.1
Device A logged in  Mobile Loop application with MobileID.
Device B logged in  Mobile Loop application with FxA.
Contact C is saved with name and email.

STRs:
1. Device A taps on "Select contact" button in Loop application.
2. Device A selects contact C -> Loop call is dialing.
3. After a few seconds, "Share link" screen is shown, selects "Email" option and sends it. --> URL shared is shown in "Shared links" screen  in Device A.
4. In device B opens browser, email server and user taps on URL shared -> StandaloneUI is open.
5. In device B, user clicks on "Start" button. -> "Conversation" screen is shown in device B.
6. In device B, user clicks on "Call" button.

Actual result:
"Oops! That didn't work as expected. Why don't we give it another try?" message is shown.

Expected result:
Call is established.
(Reporter)

Updated

3 years ago
Whiteboard: [Room1.1.1_TestRun1][Room1.1.1_Exploratory1]
One question Loli, are both applications pointing to the same server?
Flags: needinfo?(lolimartinezcr)
(Reporter)

Comment 2

3 years ago
(In reply to Maria Angeles Oteo (:oteo) from comment #1)
> One question Loli, are both applications pointing to the same server?

Both applications is point to the same server.

This is URL sent by 1.1 to 1.1.1:   https://loop-webapp-dev.stage.mozaws.net/c/1bjwlLx-NGU
Flags: needinfo?(lolimartinezcr)
Assignee: nobody → frsela
Created attachment 8553091 [details] [review]
Proposed patch

One line patch ...

In getCallUrl (client_request_helper.js) now we receive an object like [1] instead a token string.

[1] {"token":"h8FgO7daPAg","isVideoCall":true,"subject":""}
Attachment #8553091 - Flags: review?(josea.olivera)
Comment on attachment 8553091 [details] [review]
Proposed patch

LGTM, r=me with nits addressed.

Thanks for taking care of it Fernando.
Attachment #8553091 - Flags: review?(josea.olivera) → review+
Nits addressed.
Landed - https://github.com/mozilla-b2g/firefoxos-loop-client/commit/dab4ccbddd2b4c53266b2a2593394c4934ec2d8b

Thank you
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.