1124146 - Task manager should use short_name for apps when available

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Comment 1

[Ben Francis [:benfrancis]]

Hi Sam, would you be able to look into this if nobody is already working on it? Francis said in bug 1001861 that he updated the task manager spec to include this.

Comment 2

[Sam Foster [:sfoster] (he/him)]

yeah I can get this

Comment 3

[Sam Foster [:sfoster] (he/him)]

Ben, do you know if the the short_name get localized? We may need need to use the same ManifestHelper to look up the display value? 

I'm also not sure if we need can just populate a shortName property on the AppWindow instance in reConfig, or if we'll need a corollary to updateName. 

Alive, do you have any opinions on this? I'm thinking we put a shortName on the AppWindow, and use that in Card.js to prefer a shorter label for the card if one is available.

Comment 4

[Ben Francis [:benfrancis]]

As "name" can be overridden by a locales map, I guess we should assume that "short_name" can be too.

The approach you suggest sounds sensible, but I defer to Alive if he thinks differently.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

I think we should modify ManifestHelper as well as AppWindow#_handle__localized, AppWindow#reConfig.
Anyway yes AppWindow.shortName sounds sane.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:task-manager-short-name-bug-1124146 > mozilla-b2g:master

Comment 7

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8564308 [details] [review]
[gaia] sfoster:task-manager-short-name-bug-1124146 > mozilla-b2g:master

Adds manifest short_name handling to AppWindow and TaskManager/Card, + unit tests and new marionette test

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8564308 [details] [review]
[gaia] sfoster:task-manager-short-name-bug-1124146 > mozilla-b2g:master

LGTM

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6943356112f7103602f578e8436dbc7b7a60de67

Comment 10

[Hermes Cheng (inactive after July 27, 2015)]

Could you uplift to v2.2?

Comment 11

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8564308 [details] [review]
[gaia] sfoster:task-manager-short-name-bug-1124146 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Manifest short name feature
[User impact] if declined: Users may see a different label on apps on the homescreen vs. the task manager. 
[Testing completed]: On device, gaia-try. Unit and integration tests added
[Risk to taking this patch] (and alternatives if risky): Low risk - minimal patch that just affects label/title display in the task manager cards
[String changes made]: No string changes, but the change unlocks the ability for apps to show a localizable 'short_name' property from the manifest in the task manager

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9d01f232bbd95440d595b281be42f74679add714

Comment 13

[Hermes Cheng (inactive after July 27, 2015)]

Verified with below builds:

*2.2
Build ID               20150329162502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4b13c4254e2f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.200030
Firmware Date          Sun Mar 29 20:00:41 EDT 2015
Bootloader             L1TC000118D0

*master
Build ID               20150329160203
Gaia Revision          67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gaia Date              2015-03-28 10:02:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/385840329d91
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.191719
Firmware Date          Sun Mar 29 19:17:28 EDT 2015
Bootloader             L1TC100118D0