Closed
Bug 1124146
Opened 10 years ago
Closed 10 years ago
Task manager should use short_name for apps when available
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(b2g-v2.2 verified, b2g-master verified)
VERIFIED
FIXED
2.2 S6 (20feb)
People
(Reporter: benfrancis, Assigned: sfoster)
References
Details
(Keywords: feature, Whiteboard: [systemsfe])
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
alive
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Hi Sam, would you be able to look into this if nobody is already working on it? Francis said in bug 1001861 that he updated the task manager spec to include this.
Flags: needinfo?(sfoster)
Keywords: feature
Assignee | ||
Comment 2•10 years ago
|
||
yeah I can get this
Assignee: nobody → sfoster
Flags: needinfo?(sfoster)
Assignee | ||
Comment 3•10 years ago
|
||
Ben, do you know if the the short_name get localized? We may need need to use the same ManifestHelper to look up the display value? I'm also not sure if we need can just populate a shortName property on the AppWindow instance in reConfig, or if we'll need a corollary to updateName. Alive, do you have any opinions on this? I'm thinking we put a shortName on the AppWindow, and use that in Card.js to prefer a shorter label for the card if one is available.
Flags: needinfo?(bfrancis)
Flags: needinfo?(alive)
Reporter | ||
Comment 4•10 years ago
|
||
As "name" can be overridden by a locales map, I guess we should assume that "short_name" can be too. The approach you suggest sounds sensible, but I defer to Alive if he thinks differently.
Flags: needinfo?(bfrancis)
Comment 5•10 years ago
|
||
I think we should modify ManifestHelper as well as AppWindow#_handle__localized, AppWindow#reConfig. Anyway yes AppWindow.shortName sounds sane.
Flags: needinfo?(alive)
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8564308 [details] [review] [gaia] sfoster:task-manager-short-name-bug-1124146 > mozilla-b2g:master Adds manifest short_name handling to AppWindow and TaskManager/Card, + unit tests and new marionette test
Attachment #8564308 -
Flags: review?(alive)
Comment 8•10 years ago
|
||
Comment on attachment 8564308 [details] [review] [gaia] sfoster:task-manager-short-name-bug-1124146 > mozilla-b2g:master LGTM
Attachment #8564308 -
Flags: review?(alive) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6943356112f7103602f578e8436dbc7b7a60de67
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S6 (20feb)
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8564308 [details] [review] [gaia] sfoster:task-manager-short-name-bug-1124146 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Manifest short name feature [User impact] if declined: Users may see a different label on apps on the homescreen vs. the task manager. [Testing completed]: On device, gaia-try. Unit and integration tests added [Risk to taking this patch] (and alternatives if risky): Low risk - minimal patch that just affects label/title display in the task manager cards [String changes made]: No string changes, but the change unlocks the ability for apps to show a localizable 'short_name' property from the manifest in the task manager
Flags: needinfo?(sfoster)
Attachment #8564308 -
Flags: approval-gaia-v2.2?
Updated•10 years ago
|
Attachment #8564308 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 12•10 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/9d01f232bbd95440d595b281be42f74679add714
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
Comment 13•10 years ago
|
||
Verified with below builds: *2.2 Build ID 20150329162502 Gaia Revision 473cd63f53c855299b719285d9b95e3f2910782f Gaia Date 2015-03-27 20:14:43 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4b13c4254e2f Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150329.200030 Firmware Date Sun Mar 29 20:00:41 EDT 2015 Bootloader L1TC000118D0 *master Build ID 20150329160203 Gaia Revision 67ad91f3f660b1f16b354ee4c5159ddc5a74d149 Gaia Date 2015-03-28 10:02:40 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/385840329d91 Gecko Version 39.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150329.191719 Firmware Date Sun Mar 29 19:17:28 EDT 2015 Bootloader L1TC100118D0
You need to log in
before you can comment on or make changes to this bug.
Description
•