Closed
Bug 1124201
Opened 10 years ago
Closed 10 years ago
Remove NonProxyLookupOwnProperty
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
17.96 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Removes another lookup hook caller. Gets rid of some ugly code in GetOwnPropertyDescriptor as well.
Attachment #8552476 -
Flags: review?(jorendorff)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8552476 [details] [diff] [review]
non-proxy-lookup
Review of attachment 8552476 [details] [diff] [review]:
-----------------------------------------------------------------
Wow. I really appreciate this one. It's quite a nice improvement.
::: js/src/builtin/Object.cpp
@@ +575,5 @@
> CallArgs args = CallArgsFromVp(argc, vp);
>
> HandleValue idValue = args.get(0);
>
> /* Step 1, 2. */
While you're here, please adjust the comment to point out that this is a pure optimization (like the comment already in obj_propertyIsEnumerable).
Attachment #8552476 -
Flags: review?(jorendorff) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
QA Contact: evilpies
Assignee: nobody → evilpies
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•