Closed
Bug 1124235
Opened 9 years ago
Closed 9 years ago
Fix some ship-it errors 3
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(1 file)
10.85 KB,
patch
|
nthomas
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
Sounds like we submit bad data for postrelease. This is what we have for beta2 (b1 in the logs for some reason) 2015-01-21 08:35:38,082 Processing release-mozilla-beta-firefox_ready_for_release 2015-01-21 08:35:38,083 Adding new release event for Firefox-36.0b1-build2 with event_name release-mozilla-beta-firefox_ready_for_release 2015-01-21 08:35:38,084 Starting new HTTPS connection (1): ship-it.mozilla.org 2015-01-21 08:35:38,181 "HEAD /csrf_token HTTP/1.1" 200 0 2015-01-21 08:35:38,182 Request to https://ship-it.mozilla.org/releases/Firefox-36.0b1-build2/status 2015-01-21 08:35:38,182 Data sent: {'csrf_token': 'xxxxx', 'group': u'release', 'event_name': u'release-mozilla-beta-firefox_ready_for_release', 'results': 0, u' platform': None, 'sent': '2015-01-21 16:35:38'} 2015-01-21 08:35:38,182 retry: Calling request with args: (), kwargs: {'params': None, 'timeout': 60, 'url': u'https://ship-it.mozilla.org/releases/Firefox-36.0b1-build2/status', 'config': {'danger_mode': True}, 'data': {'csrf_token': 'xxxxx', 'group': u'release', 'event_name': u'release-mozilla-beta-firefox_ready_for_release', 'results': 0, u'platform': None, 'sent': '2 015-01-21 16:35:38'}, 'method': 'POST', 'auth': ('xxxxx', 'xxxxx')}, attempt #1 2015-01-21 08:35:38,183 Starting new HTTPS connection (2): ship-it.mozilla.org 2015-01-21 08:35:38,288 "POST /releases/Firefox-36.0b1-build2/status HTTP/1.1" 400 100 2015-01-21 08:35:38,289 retry: Caught exception: Traceback (most recent call last): File "/builds/shipit_notifier/tools/lib/python/util/retry.py", line 33, in retry return action(*args, **kwargs) File "/builds/shipit_notifier/tools/lib/python/vendor/requests-0.10.8/requests/sessions.py", line 203, in request r.send(prefetch=prefetch) File "/builds/shipit_notifier/tools/lib/python/vendor/requests-0.10.8/requests/models.py", line 585, in send self.response.raise_for_status() File "/builds/shipit_notifier/tools/lib/python/vendor/requests-0.10.8/requests/models.py", line 810, in raise_for_status raise http_error HTTPError: 400 Client Error 2015-01-21 16:35:46,157 - kickoff.views.status.post#61: ReleaseEvents (Firefox-36.0b1-build2, release-mozilla-beta-firefox_ready_for_release) already exists
Assignee | ||
Comment 1•9 years ago
|
||
s/postrelease/ready_for_release/
Assignee | ||
Comment 2•9 years ago
|
||
Sounds like the dummy builders are not recreated by reconfigs... compare_attrs with no properties I bet...
Assignee | ||
Comment 3•9 years ago
|
||
Looks like builder properties are ignored in http://hg.mozilla.org/build/buildbot/file/b67b542e9b18/master/buildbot/process/builder.py#l429 when you reconfig. It kind of makes sense because they could be dynamic. The patch should make buildbot reload the builders whenever we bump the release configs.
Attachment #8552643 -
Flags: review?(nthomas)
Comment 4•9 years ago
|
||
Comment on attachment 8552643 [details] [diff] [review] dummy-buildbotcustom.diff lgtm
Attachment #8552643 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8552643 [details] [diff] [review] dummy-buildbotcustom.diff https://hg.mozilla.org/build/buildbotcustom/rev/52856513ac37
Attachment #8552643 -
Flags: checked-in+
Comment 6•9 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/52856513ac37
Assignee | ||
Comment 7•9 years ago
|
||
It worked!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•