Closed Bug 1124368 Opened 10 years ago Closed 10 years ago

Shutdown profile dumping is broken, accesses deleted markers from shutdown threads

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38

People

(Reporter: mstange, Assigned: mstange)

References

Details

MOZ_PROFILER_STARTUP=true MOZ_PROFILER_SHUTDOWN=$PWD/myprofile.sps mach run crashes on shutdown. This was probably triggered by the change that made us profile the compositor thread by default. What happens is that compositor thread shutdown deletes its PseudoStack, which deletes the markers. But the ThreadProfile for the compositor thread stays alive, and it has pointers to those deleted markers, and when we want to dump the compositor ThreadProfile we access those markers and crash.
We should really add a test for this. GTest might not be too bad to write for this.
Depends on: 1127498
Fixed by bug 1127498.
Assignee: nobody → mstange
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.