Shutdown profile dumping is broken, accesses deleted markers from shutdown threads

RESOLVED FIXED in mozilla38

Status

()

Core
Gecko Profiler
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla38
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

3 years ago
MOZ_PROFILER_STARTUP=true MOZ_PROFILER_SHUTDOWN=$PWD/myprofile.sps mach run
crashes on shutdown. This was probably triggered by the change that made us profile the compositor thread by default.

What happens is that compositor thread shutdown deletes its PseudoStack, which deletes the markers. But the ThreadProfile for the compositor thread stays alive, and it has pointers to those deleted markers, and when we want to dump the compositor ThreadProfile we access those markers and crash.
We should really add a test for this. GTest might not be too bad to write for this.
(Assignee)

Updated

3 years ago
Depends on: 1127498
(Assignee)

Comment 2

3 years ago
Fixed by bug 1127498.
Assignee: nobody → mstange
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.