1124381 - direct user sees "something went wrong" rather than "contact unavailable" if the callee doesn't answer/rejects

Status: RESOLVED WONTFIX

(Hello (Loop) :: Client, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Given this amount of user training, I'm concerned that a substantial number of users may interpret every "didn't answer" as "the system is broken right now", which would effectively make the product seem extremely broken to those people, even when it's not.

Right now, reason=timeout in the client code covers several things:

* call not answered
* the other user is not logged in

and 

* call failed during setup

We need to display the "contact unavailable" message for the first two cases, but not the last one.

Bug 1119992 is the better long term fix for this bug, and requires protocol changes (discussed in bug 1120375). 

[Tracking requested because:]

It _should_ be possible to fix these without protocol changes in a way that's easier to uplift as far as 36 (which we want for cleanliness of metrics, in addition to the UX win) by tracking the previous server websocket state in the client-side code (see bug 1120375 for more details.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Note that for outgoing calls, the states are handled as loop.store.WS_STATES.  For incoming calls, which haven't yet been fluxified, they're handled elsewhere.  It's not obvious to me at first glance whether we'll need to fix both sides of the call for this bug (which is just about the caller seeing the right thing).

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

I'm marking 35+ as affected but don't think we need to track this. I'm happy to consider an uplift that doesn't break string freeze on Beta and Aurora.

Comment 3

[Mark Banner (:standard8)]

We are currently reworking the Loop "user journey" (bug 1209713) and as part of this direct calls and contacts are being removed. Therefore closing direct call related bugs as wontfix.

Tracking id: directcallclosing