Telemetry: Record the number of passwords per hostname

RESOLVED FIXED in Firefox 37

Status

()

defect
P1
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ckarlof, Assigned: liuche)

Tracking

(Blocks 1 bug)

unspecified
mozilla38
Points:
3
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox36 affected, firefox37 fixed, firefox38 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

There are many ways we could refine this, but I propose that we first do this as naively as possible (i.e, exact origin match of the page where the password was captured).
Priority: -- → P1
We're just going to measure: what are the number of domains with x number of logins

Possible reasons that a user might see multiple logins:
* Multiple accounts for the page
* http and https for same domain (different origin)
* Subdomains of same etld + 1 (~second level domain)
* Same domain, different port
* Different http realms for same origin
* maybe? different formsubmiturl for same domain/login

Other thoughts:
This might be useful for deciding how we prioritize UI for selecting from multiple accounts?
How many passwords can be combined once we improve origin handling?
(if we were perfect) How many accounts do people have for the same website?
Status: NEW → ASSIGNED
Summary: Telemetry: Record the number of domains for which the user has multiple sets of saved credentials → Telemetry: Record the number of domains that have that have "x" number of logins
Points: --- → 3
Summary: Telemetry: Record the number of domains that have that have "x" number of logins → Telemetry: Record the number of passwords per hostname
/r/3209 - Bug 1124392 - Record the number of passwords per hostname. r=MattN

Pull down this commit:

hg pull review -r 27acb5026a4ca21f8d3dbce26e2521386321c2ac
Attachment #8557456 - Flags: review?(MattN+bmo)
Depends on: 1124516
Comment on attachment 8557456 [details]
MozReview Request: bz://1124392/liuche

Clearing review because I forgot to rebase over Paolo's WS patch x_x
Attachment #8557456 - Flags: review?(MattN+bmo)
Attachment #8557534 - Flags: review?(MattN+bmo)
Comment on attachment 8557534 [details] [diff] [review]
Rebased on top of bug 1124516

Review of attachment 8557534 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/nsLoginManager.js
@@ +271,5 @@
> +
> +    let passwordsCountHistogram = clearAndGetHistogram("PWMGR_NUM_HOSTNAME_PASSWORDS");
> +    log("hostnameCount.size", hostnameCount.size);
> +    for (let count of hostnameCount.values()) {
> +      log("AOEU value", count);

Leftover logging x2?

::: toolkit/components/telemetry/Histograms.json
@@ +7261,5 @@
>      "n_buckets" : 10,
>      "extended_statistics_ok": true,
>      "description": "The number of sites for which the user has explicitly rejected saving logins"
>    },
> +  "PWMGR_NUM_HOSTNAME_PASSWORDS": {

Nit: we could make this more clear with the name PWMGR_NUM_PASSWORDS_PER_HOSTNAME

@@ +7265,5 @@
> +  "PWMGR_NUM_HOSTNAME_PASSWORDS": {
> +    "expires_in_version": "never",
> +    "kind": "exponential",
> +    "high": 100,
> +    "n_buckets" : 50,

Linear to 20?

@@ +7266,5 @@
> +    "expires_in_version": "never",
> +    "kind": "exponential",
> +    "high": 100,
> +    "n_buckets" : 50,
> +    "extended_statistics_ok": true,

Remove this for linear.
Attachment #8557534 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/9c18e56a7b50
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8557534 [details] [diff] [review]
Rebased on top of bug 1124516

Approval Request Comment
[Feature/regressing bug #]: Improvements to password manager in 2015 - Bug 1121127
[User impact if declined]: Possibly less ideal decisions based on lack of data.
[Describe test coverage new/current, TreeHerder]: No tests for the telemetry since it's outside the normal code flow so shouldn't break other aspects of password manager if an exception occurs. No problems have been reported on Nightly and data looks good there.
[Risks and why]: Low risk since it's new code only run during the telemetry gathering phase.
[String/UUID change made/needed]: None
Attachment #8557534 - Flags: approval-mozilla-beta?
Attachment #8557534 - Flags: approval-mozilla-aurora?
Comment on attachment 8557534 [details] [diff] [review]
Rebased on top of bug 1124516

I'm not sure about the value of uplifting this patch to Beta at this point in the cycle. (I'll leave it to Sylvestre to make the call on that.) Happy to take this on Aurora.

Aurora+
Attachment #8557534 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8557534 [details] [diff] [review]
Rebased on top of bug 1124516

Too late for beta.
Attachment #8557534 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Flags: qe-verify-
Attachment #8557456 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.