1124401 - Explicitly depend on DateTime::TimeZone::Local::Win32 on Windows

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

From a discussion on IRC, I have discovered that recent versions of DateTime::TimeZone do not ship with the Win32 modules. It was split off into another package. Also, as of 1.84, that package does not depend on DateTime::TimeZone::Local::Win32 at all. This results in mysterious errors for people installing Bugzilla on win32.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

This is something that will have to be fixed in Bugzilla packaging side, rather than in DateTime::TimeZone.

> 17:15 <dylan> if I depend on DateTime::TimeZone, after 1.84 it won't work on win32
> 17:15 <dylan> that is, the Win32 part won't be installed.
> 17:15 <autarch> dylan: you'll have to add your own OSPrereq
> 17:15 <dylan> k

Comment 2

[Mike Brotherton]

At a minimum, a note needs to be made about the potential need for DateTime::TimeZone::Local::Win32 in the Windows-specific installation instructions.

Comment 3

[Anry]

(In reply to Dylan William Hardison [:dylan] from comment #1)
> This is something that will have to be fixed in Bugzilla packaging side,
> rather than in DateTime::TimeZone.
> 
> > 17:15 <dylan> if I depend on DateTime::TimeZone, after 1.84 it won't work on win32
> > 17:15 <dylan> that is, the Win32 part won't be installed.
> > 17:15 <autarch> dylan: you'll have to add your own OSPrereq
> > 17:15 <dylan> k

Can you tell me how to install

Comment 4

[Andre Klapper]

Anry: Support requests are not handled in Bugzilla. For support requests (changing the settings, adjusting your installation, questions how to do something), please see http://www.bugzilla.org/support/ - Thanks.

Comment 5

[Andre Klapper]

Teemu: Argh, sorry (stock answer also setting status) and thanks for reopening. :(

Comment 6

[Frédéric Buclin]

Attachment: patch, v1

Comment 7

[Frédéric Buclin]

FYI, I tested my patch on Windows 7 with IIS, and confirm that without DateTime::TimeZone::Local::Win32, DateTime::TimeZone is unable to determine the local time.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8598802 [details] [diff] [review]
patch, v1

Review of attachment 8598802 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 9

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   37bbf30..cd263e8  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   f261808..ca21e3a  5.0 -> 5.0

Comment 10

[wskellenger]

This issue affects 'stable' 4.4.x also -- just wondering if this fix will make it into 4.4 (or older?) as well...

Comment 11

[Frédéric Buclin]

(In reply to wskellenger from comment #10)
> This issue affects 'stable' 4.4.x also -- just wondering if this fix will
> make it into 4.4 (or older?) as well...

We usually don't edit the list of required modules once a branch is in its stable state, but in that specific case, this is not exactly a real new dependency as we were already indirectly depending on it via DateTime::TimeZone. When the module has been split earlier this year (January 2015), the missing dependency on the Win32-specific module suddenly became visible to Windows users. So personally, I would agree that it would make sense to backport the patch to 4.4 as Bugzilla will fail without it on Windows anyway.

glob, your opinion?

Comment 12

[wskellenger]

Thank you Frédéric, I came to this issue from Bug 604942, when I discovered the problem on my brand new install (last week) of 4.4.9.  I just Google'd the problem and ran into 604942 containing the solution (which officially is documented here).

Comment 13

[:glob ✱]

(In reply to Frédéric Buclin from comment #11)
> So personally, I would agree that it would
> make sense to backport the patch to 4.4 as Bugzilla will fail without it on
> Windows anyway.
> 
> glob, your opinion?

ok

Comment 14

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   85c1d41..df9b5af  4.4 -> 4.4

Comment 15

[Jacob]

Hi

I have similar issue getting error while posting bug " post_bug.cgi: Cannot determine local time zone "

I ran "ppm install DateTime-TimeZone-Local-Win32" but it it's not showing up when I run checksetup.pl
When I try install again it shows as it is already installed 

I guess you have provided the patch above ? not sure how to run it sorry I am new to bugzilla 

Thanks

Jacob

Comment 16

[Frédéric Buclin]

My patch is not needed to make Bugzilla work. It only checks that the Win32-specific module is installed correctly. If that's the case, Bugzilla should work correctly.