Explicitly depend on DateTime::TimeZone::Local::Win32 on Windows

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
Installation & Upgrading
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: dylan, Assigned: Frédéric Buclin)

Tracking

unspecified
Bugzilla 4.4
Bug Flags:
approval +
approval5.0 +
blocking5.0 +
approval4.4 +

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
From a discussion on IRC, I have discovered that recent versions of DateTime::TimeZone do not ship with the Win32 modules. It was split off into another package. Also, as of 1.84, that package does not depend on DateTime::TimeZone::Local::Win32 at all. This results in mysterious errors for people installing Bugzilla on win32.
(Reporter)

Comment 1

3 years ago
This is something that will have to be fixed in Bugzilla packaging side, rather than in DateTime::TimeZone.

> 17:15 <dylan> if I depend on DateTime::TimeZone, after 1.84 it won't work on win32
> 17:15 <dylan> that is, the Win32 part won't be installed.
> 17:15 <autarch> dylan: you'll have to add your own OSPrereq
> 17:15 <dylan> k

Comment 2

3 years ago
At a minimum, a note needs to be made about the potential need for DateTime::TimeZone::Local::Win32 in the Windows-specific installation instructions.

Comment 3

3 years ago
(In reply to Dylan William Hardison [:dylan] from comment #1)
> This is something that will have to be fixed in Bugzilla packaging side,
> rather than in DateTime::TimeZone.
> 
> > 17:15 <dylan> if I depend on DateTime::TimeZone, after 1.84 it won't work on win32
> > 17:15 <dylan> that is, the Win32 part won't be installed.
> > 17:15 <autarch> dylan: you'll have to add your own OSPrereq
> > 17:15 <dylan> k

Can you tell me how to install

Comment 4

3 years ago
Anry: Support requests are not handled in Bugzilla. For support requests (changing the settings, adjusting your installation, questions how to do something), please see http://www.bugzilla.org/support/ - Thanks.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

Comment 5

3 years ago
Teemu: Argh, sorry (stock answer also setting status) and thanks for reopening. :(
(Assignee)

Updated

2 years ago
Flags: blocking5.0?
Target Milestone: --- → Bugzilla 5.0
(Assignee)

Comment 6

2 years ago
Created attachment 8598802 [details] [diff] [review]
patch, v1
Assignee: installation → LpSolit
Status: REOPENED → ASSIGNED
Attachment #8598802 - Flags: review?(dylan)
Flags: blocking5.0? → blocking5.0+
(Assignee)

Updated

2 years ago
Summary: We need to depend on DateTime::TimeZone::Local::Win32 for newer versions of DateTime::TimeZone on Win32 → Explicitly depend on DateTime::TimeZone::Local::Win32 on Windows
(Assignee)

Comment 7

2 years ago
FYI, I tested my patch on Windows 7 with IIS, and confirm that without DateTime::TimeZone::Local::Win32, DateTime::TimeZone is unable to determine the local time.
(Assignee)

Updated

2 years ago
Attachment #8598802 - Flags: review?(dylan) → review?(glob)
Attachment #8598802 - Flags: review?(glob) → review?(dylan)
(Reporter)

Comment 8

2 years ago
Comment on attachment 8598802 [details] [diff] [review]
patch, v1

Review of attachment 8598802 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8598802 - Flags: review?(dylan) → review+
(Assignee)

Updated

2 years ago
Flags: approval?
Flags: approval5.0?
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval+
(Assignee)

Comment 9

2 years ago
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   37bbf30..cd263e8  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   f261808..ca21e3a  5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago2 years ago
Resolution: --- → FIXED

Comment 10

2 years ago
This issue affects 'stable' 4.4.x also -- just wondering if this fix will make it into 4.4 (or older?) as well...
(Assignee)

Comment 11

2 years ago
(In reply to wskellenger from comment #10)
> This issue affects 'stable' 4.4.x also -- just wondering if this fix will
> make it into 4.4 (or older?) as well...

We usually don't edit the list of required modules once a branch is in its stable state, but in that specific case, this is not exactly a real new dependency as we were already indirectly depending on it via DateTime::TimeZone. When the module has been split earlier this year (January 2015), the missing dependency on the Win32-specific module suddenly became visible to Windows users. So personally, I would agree that it would make sense to backport the patch to 4.4 as Bugzilla will fail without it on Windows anyway.

glob, your opinion?
Flags: needinfo?(glob)

Comment 12

2 years ago
Thank you Frédéric, I came to this issue from Bug 604942, when I discovered the problem on my brand new install (last week) of 4.4.9.  I just Google'd the problem and ran into 604942 containing the solution (which officially is documented here).
(In reply to Frédéric Buclin from comment #11)
> So personally, I would agree that it would
> make sense to backport the patch to 4.4 as Bugzilla will fail without it on
> Windows anyway.
> 
> glob, your opinion?

ok
Flags: needinfo?(glob) → approval4.4+
Target Milestone: Bugzilla 5.0 → Bugzilla 4.4
(Assignee)

Comment 14

2 years ago
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   85c1d41..df9b5af  4.4 -> 4.4

Comment 15

2 years ago
Hi

I have similar issue getting error while posting bug " post_bug.cgi: Cannot determine local time zone "

I ran "ppm install DateTime-TimeZone-Local-Win32" but it it's not showing up when I run checksetup.pl
When I try install again it shows as it is already installed 

I guess you have provided the patch above ? not sure how to run it sorry I am new to bugzilla 

Thanks

Jacob
Flags: needinfo?(LpSolit)
(Assignee)

Comment 16

2 years ago
My patch is not needed to make Bugzilla work. It only checks that the Win32-specific module is installed correctly. If that's the case, Bugzilla should work correctly.
Flags: needinfo?(LpSolit)
You need to log in before you can comment on or make changes to this bug.