1124507 - [Wifi Direct] Some attributes of mozWifiP2pManager aren't properly initialized across connection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

At the time constructing mozWifiP2pManager [1], some attributes should be initialized

[1] http://hg.mozilla.org/mozilla-central/file/34e2d2bd7ec4/dom/wifi/DOMWifiP2pManager.js#l116

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug1124507.patch

Comment 2

[Henry Chang [:hchang]]

Here's a short explanation of what this patch does:

In the construction phase of MozWifiP2pManager, it would send a sync message
to the wifi p2p internal to get the current state. The original code doesn't
fetch all the internal information of wifi p2p. So, the patch adds the code
to retain the state in WifiP2pWorkerObserver and send to DOMWifiP2pManager
whenever needed.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8555189 [details] [diff] [review]
Bug1124507.patch

Review of attachment 8555189 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you.

::: dom/wifi/WifiP2pWorkerObserver.jsm
@@ +40,5 @@
>    let _peerList = {}; // List of P2pDevice.
>    let _domManagers = [];
> +  let _enabled = false;
> +  let _groupOwner;
> +  let _currentPeer;

Nit: please give default value to _groupOwner and _currentPeer.

Comment 4

[Henry Chang [:hchang]]

Attachment: Bug1124507_V2.patch (r+'d)

Addressed the review comment

Comment 5

[Henry Chang [:hchang]]

Thanks Vincent!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e677031ae36b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fbc6b6da6597

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fbc6b6da6597