Avoid creating the mergedFeatures hash table when possible

RESOLVED FIXED in mozilla38

Status

()

Core
Graphics: Text
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
When scrolling all the way through
https://bugzilla.mozilla.org/show_bug.cgi?id=MNG, |mergedFeatures| gets
initialized more than 50,000 times -- each one involving a heap allocation for
the entry storage -- but it never has anything put into it.

This patch moves |mergedFeatures| into MergeFontFeatures(), which allows it to
not be created in the common case.
(Assignee)

Comment 1

3 years ago
Created attachment 8552871 [details] [diff] [review]
Avoid creating the mergedFeatures hash table when possible
Attachment #8552871 - Flags: review?(jdaggett)
(Assignee)

Updated

3 years ago
Depends on: 1094552

Comment 2

3 years ago
Comment on attachment 8552871 [details] [diff] [review]
Avoid creating the mergedFeatures hash table when possible

Review of attachment 8552871 [details] [diff] [review]:
-----------------------------------------------------------------

looks good!
Attachment #8552871 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 3

3 years ago
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ec92f5b6980
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7060fb7bb084
https://hg.mozilla.org/mozilla-central/rev/7060fb7bb084
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.