Closed
Bug 1124545
Opened 11 years ago
Closed 11 years ago
Avoid creating the mergedFeatures hash table when possible
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
11.81 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
When scrolling all the way through
https://bugzilla.mozilla.org/show_bug.cgi?id=MNG, |mergedFeatures| gets
initialized more than 50,000 times -- each one involving a heap allocation for
the entry storage -- but it never has anything put into it.
This patch moves |mergedFeatures| into MergeFontFeatures(), which allows it to
not be created in the common case.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8552871 -
Flags: review?(jdaggett)
|
|
Assignee | |
Updated•11 years ago
|
Depends on: cumulative-heap-profiling
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8552871 [details] [diff] [review]
Avoid creating the mergedFeatures hash table when possible
Review of attachment 8552871 [details] [diff] [review]:
-----------------------------------------------------------------
looks good!
Attachment #8552871 -
Flags: review?(jdaggett) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•