1124582 - [RTL][Video]The title "1 selected" does not read right to left.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect, P2)

Description

[Sue]

Attachment: 2014-06-01-13-33-43.png

[1.Description]:
[RTL][Video]When you tap "select" button for selecting a video, the title "1 selected" at top of page does not read right to left.
Found time:13:33
See attachment:2014-06-01-13-33-43.png and logcat_1333.txt

[2.Testing Steps]: 
Prerequisite: Set the system language as Arabic and device has at least one video in Video app.
1. Launch Video app.
2. Tap the select button at right bottom.
3. Select a video.

[3.Expected Result]: 
3. The title "1 selected" should read right to left.

[4.Actual Result]: 
3. The title "1 selected" does not read right to left.

[5.Reproduction build]: 
Flame 2.2 build:
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4a90da67661e
Build-ID        20150121162503
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150121.201218
FW-Date         Wed Jan 21 20:12:28 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
This issue also happens on Gallery, Contacts, Messages app.

Comment 1

[Sue]

Attachment: logcat_1333.txt

Comment 2

[Hema Koka [:hema]]

Russ, 

Could you take this up?

Thanks
Hema

Comment 3

[David Flanagan [:djf]]

Note that the "1 selected" string is in the gaia-header component, so this bug could be related to that component. Wilson is working on a fix (unknown bug number) that should land soon, and might resolve this one as well.

Does the Gallery app have the same bug? If so, then hopefully both will be fixed by a gaia-header patch. If not, then the Video app should be able to just do whatever Gallery does.

Comment 4

[David Flanagan [:djf]]

Wilson: do you think that your gaia-header patch will fix this bug?

Comment 5

[Sue]

(In reply to David Flanagan [:djf] from comment #3)
> Does the Gallery app have the same bug? If so, then hopefully both will be
> fixed by a gaia-header patch. If not, then the Video app should be able to
> just do whatever Gallery does.

Yes, I have noted it in description. This issue also happened on Gallery, Contacts, Messages and Phone app.

Comment 6

[Hema Koka [:hema]]

Wilson mentioned he could fix this easily. Removing NI for Russ (Russ, if wilson needs help verifying the fix, please take that up)

Comment 7

[Wilson Page [:wilsonpage]]

Attachment: pull-request(gaia-header:master)

Comment 8

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Comment on attachment 8556001 [details] [review]
pull-request(gaia-header:master)

r=me

thanks !

Unrelated to your change, I saw that "1 selected" is not retranslated when we change the language. Please file a separate bug if it should be fixed.

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8556001 [details] [review]
pull-request(gaia-header:master)

LANDED https://github.com/gaia-components/gaia-header/commit/fd2d4a6a04254bcfccea0c330d496f86edb23e24

STAMPED v0.6.1 https://github.com/gaia-components/gaia-header/releases/tag/v0.6.1

Comment 11

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

PR for Gaia: https://github.com/mozilla-b2g/gaia/pull/27959

Comment 12

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

PR for Gaia v2.2: https://github.com/mozilla-b2g/gaia/pull/27960

Comment 13

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

master: https://github.com/mozilla-b2g/gaia/commit/8cade57c020f952bfe561c76f4afbcc51029e25a
v2.2: https://github.com/mozilla-b2g/gaia/commit/0b0e8e97e6b5bb34d58fcc5509daa7935a4f82b8

Comment 14

[Coler]

This issue has been verified on Flmae 2.2/3.0
Attachment:Verify_RTL_Video.png

Flame 2.2:
Gaia-Rev        791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/dcf030ef499d
Build-ID        20150211162505
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150211.194909
FW-Date         Wed Feb 11 19:49:19 EST 2015
Bootloader      L1TC000118D0

Flame3.0:

Gaia-Rev        e280a660955bbdab265d50f8d9e009de34082332
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/650863f6987b
Build-ID        20150211160231
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150211.192431
FW-Date         Wed Feb 11 19:24:42 EST 2015
Bootloader      L1TC000118D0

Comment 15

[Coler]

Attachment: Verify_RTL_Video.png

Comment 16

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15346/