1124624 - Add transition to the group view panel

Status: RESOLVED DUPLICATE of bug 1162030

(Firefox OS Graveyard :: Gaia::SMS, enhancement)

Description

[Vishnu Teja [:ythej]]

Steps to reproduce:
1. Open sms app.
2. open any message thread which has more than one recipients.
3. tap on the header text.

Expected result:
Transition should be there while we move to group view panel

Actual result:
There is no transition taken while we move to group view panel

Comment 1

[Vishnu Teja [:ythej]]

Hi Jenny,
Could you give your opinion on this bug?
Thank you.

Comment 2

[Jenny Lee]

Hi Vishnu,

I agree we should have a slide in from right transition here. Please refer to the transition: inbox --> (tap on a thread) --> thread view. Thanks!

Comment 3

[Vishnu Teja [:ythej]]

As Julien suggested we may implement off canvas technique to slide between the panels.For that we may have

*Thread-list panel -> left
*Thread-ui panel -> middle
*group-view -> right

So, we may add classes to main-wrapper to display each panel in the wrapper(indirectly we are moving the whole wrapper left/right).This can be done assigning negative values for margin.

Thanks Julien for proposing with this idea ! :)

Comment 4

[Julien Wajsberg [:julienw]]

You can try margin, "position: absolute", or even possibly a "display: flex" solution.

Comment 5

[GitHub Autolander Bot]

Attachment: [PullReq] ythej:bug_1124624 to mozilla-b2g:master

Comment 6

[Vishnu Teja [:ythej]]

Attachment: pull request for the bug fix 1124624

Hi Julien,

When I open the sms app I am able to see the thread_list_ui but when I tried to move to thread_ui, i am seeing a blank page.But inspector shows that we are in  thread-messages.

Thank you.

Comment 7

[Julien Wajsberg [:julienw]]

Answered on github :)

Comment 8

[Julien Wajsberg [:julienw]]

This has been fixed by bug 1162030 :)