1124703 - Page-Mod worker 'pageshow' event no longer fired in FF 36

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Raymond]

Attachment: ff-worker-bug.xpi

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.91 Safari/537.36

Steps to reproduce:

Attach an event listener for pageshow for workers for scripts injected into web pages.  We use this event in our Add to Wunderlist extension in order to track and communicate with the correct active tab worker.

The example addon logs several events from pagemod workers, on FF 35 the pageshow event is logged correctly.


Actual results:

pageshow event never fired in FF 36 or later


Expected results:

pageshow event should be fired in FF 36 as it was in FF 35

Comment 1

[Raymond]

This bug breaks our extension here and we have already received a review mentioning this issue from a user: https://addons.mozilla.org/en-US/firefox/addon/add-to-wunderlist/

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

STR:

1) Set extensions.sdk.console.logLevel to "all".
2) Install the sample extension.
3) Open the Browser Console.
4) Visit any site, like example.com

Actual:

Three log entries: onAttach, injected.

Expected:

Three log entries: onAttach, pageshow, injected.

Comment 3

[Alice0775 White]

Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=758d1cb4568b&tochange=201edc7cadb5

Regressed by:
201edc7cadb5	Dave Townsend — Bug 1083327: Uplift Add-on SDK.

Comment 4

[Dave Townsend [:mossop]]

Any idea what caused this zombie?

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking for add-on compat.

Comment 6

[Dave Townsend [:mossop]]

This appears to be a timing issue with the switch to asynchronous attachment to support e10s. When the page starts loading we notify the parent (I think synchronously), which then checks if a page-mod matches and asynchronously attaches the worker-child. That races against the page loading and so the worker can attach after the page has already loaded and fired its pageshow event.

Subsequent pageshow and pagehide events come through just fine. We can probably fix this by checking if the page has already loaded when attaching a worker and if so firing a mock pageshow event.

Comment 7

[Dave Townsend [:mossop]]

Attachment: pull request

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Dave, as we are getting closer and closer to the release, could you request the review from someone else? Thanks

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8556749 [details] [review]
pull request

Looks good, r+

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e8c43203c424255b77176bdb9fe61945949b8baf
Bug 1124703: Send synthetic pageshow events when asynchronous message passing mean that we miss the real ones.

https://github.com/mozilla/addon-sdk/commit/0ddcbe6ac53eded4864feac6921aa50273437bd2
Merge pull request #1852 from Mossop/bug1124703

Bug 1124703: Send synthetic pageshow events when asynchronous message passing mean that we miss the real ones. r=jsantell

Comment 11

[Dave Townsend [:mossop]]

Directly uplifted:

https://hg.mozilla.org/integration/fx-team/rev/ba2ca7e6f474

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba2ca7e6f474

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Dave, could you fill the uplift request? Thanks

Comment 14

[Dave Townsend [:mossop]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #13)
> Dave, could you fill the uplift request? Thanks

We should take bug 1129567 instead which will fix this.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

OK, I guess this is the same for 37.

Comment 16

[Dave Townsend [:mossop]]

Fixed on aurora and beta by reverting page-mod in bug 1129567