1124716 - regression caused by bug 1090275 to whitelist webservice methods causes test failures with t/012throwables.t

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[David Lawrence [:dkl]]

the patch committed (and released) from bug 1090275 caused a regression. The change doesn't pass tests, and burned all the trees:

#   Failed test 'Bugzilla/WebService/Server/JSONRPC.pm has 1 error(s):
# user error tag 'unknown_method' is used at line(s) (410) but not defined for language(s): any'
#   at t/012throwables.t line 202.
# Looks like you failed 1 test of 217.

Moral of the story: Never release before Travis has finished all runs after patches are committed :( Just wish Travis was faster.

patch coming

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch for all versions v.1

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8553162 [details] [diff] [review]
Patch for all versions v.1

Review of attachment 8553162 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is the wrong patch?

r-

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch for all versions v.1

Correct patch. I blame the medication :)

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8553168 [details] [diff] [review]
Patch for all versions v.1

Review of attachment 8553168 [details] [diff] [review]:
-----------------------------------------------------------------

For some reason, in JSONRPC the method name method name... err, that is, bz_method_name is prefixed with an _. This will still result in a 500 error.

::: Bugzilla/WebService/Server/JSONRPC.pm
@@ +390,4 @@
>  
>      # Only allowed methods to be used from our whitelist
>      if (none { $_ eq $method} $pkg->PUBLIC_METHODS) {
> +        ThrowCodeError('unknown_method', { method => $self->bz_method_name });

note: wrong method name, needs to be _bz_method_name().

Comment 5

[David Lawrence [:dkl]]

Attachment: 1124716_2.patch

Ugh. darn medication again.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8553176 [details] [diff] [review]
1124716_2.patch

Review of attachment 8553176 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

a proper error message for JSONRPC!

Comment 7

[:glob ✱]

there's no need to request blocking & approval at the same time for the same branch.

a=glob, please release this asap.

Comment 8

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   bb16842..b8575ad  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   ce8c9ca..cce0385  5.0 -> 5.0

To ssh://[e-mail]/bugzilla/bugzilla.git
   25c0962..6d5669f  4.4 -> 4.4

To ssh://[e-mail]/bugzilla/bugzilla.git
   7c58944..ecf2254  4.2 -> 4.2

To ssh://[e-mail]/bugzilla/bugzilla.git
   c4dbb67..2ba0823  4.0 -> 4.0