1124759 - Include more data in mozreview.commits.published Pulse message

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Steven MacLeod [:smacleod]]

In order to allow commenting on the actual commits consumers need to
have the diffset revision for each review request. The new message
will include the parent's diffset revision, as well as a diffset
revision for each child.

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: MozReview Request: bz://1124759/smacleod

/r/2853 - mozreview: Include more data in mozreview.commits.published Pulse message (Bug 1124759). r=gps

Pull down this commit:

hg pull review -r df99c66264cd4680c893d41dae02884a2e9e0db5

Comment 2

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/2853/#review2105

::: pylib/mozreview/mozreview/pulse/__init__.py
(Diff revision 1)
> +    msg.data['prent_diffset_revision'] = review_request.get_latest_diffset().revision

prent?

::: hgext/reviewboard/tests/test-pulse-publishing.t
(Diff revision 1)
> +    prent_diffset_revision: 1

prent?

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8553217 [details]
MozReview Request: bz://1124759/smacleod

https://reviewboard.mozilla.org/r/2851/#review2107

Ship It!

Comment 4

[Steven MacLeod [:smacleod]]

Pushed: https://hg.mozilla.org/hgcustom/version-control-tools/rev/7ef52d25d8dc

Comment 6

[Steven MacLeod [:smacleod]]

Attachment: MozReview Request: mozreview: Include more data in mozreview.commits.published Pulse message (Bug 1124759). r=gps