Closed Bug 1124759 Opened 7 years ago Closed 7 years ago

Include more data in mozreview.commits.published Pulse message

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Version:
Development/Staging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: smacleod, Assigned: smacleod)

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: mozreview: Include more data in mozreview.commits.published Pulse message (Bug 1124759). r=gps
39 bytes, text/x-review-board-request
gps
: review+
Details 
In order to allow commenting on the actual commits consumers need to
have the diffset revision for each review request. The new message
will include the parent's diffset revision, as well as a diffset
revision for each child.
/r/2853 - mozreview: Include more data in mozreview.commits.published Pulse message (Bug 1124759). r=gps

Pull down this commit:

hg pull review -r df99c66264cd4680c893d41dae02884a2e9e0db5
Attachment #8553217 - Flags: review?(gps)
https://reviewboard.mozilla.org/r/2853/#review2105

::: pylib/mozreview/mozreview/pulse/__init__.py
(Diff revision 1)
> +    msg.data['prent_diffset_revision'] = review_request.get_latest_diffset().revision

prent?

::: hgext/reviewboard/tests/test-pulse-publishing.t
(Diff revision 1)
> +    prent_diffset_revision: 1

prent?
Comment on attachment 8553217 [details]
MozReview Request: bz://1124759/smacleod

https://reviewboard.mozilla.org/r/2851/#review2107

Ship It!
Attachment #8553217 - Flags: review?(gps) → review+
Pushed: https://hg.mozilla.org/hgcustom/version-control-tools/rev/7ef52d25d8dc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attachment #8553217 - Attachment is obsolete: true
Attachment #8619210 - Flags: review+
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.