Closed
Bug 112479
Opened 24 years ago
Closed 24 years ago
HTTP needs complete support for nsIUploadChannel
Categories
(Core :: Networking: HTTP, defect, P1)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla0.9.8
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
Attachments
(1 file, 1 obsolete file)
|
5.04 KB,
patch
|
dougt
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
HTTP needs complete support for nsIUploadChannel
|
Assignee | |
Updated•24 years ago
|
Severity: normal → major
Status: NEW → ASSIGNED
Keywords: mozilla1.0
Priority: -- → P2
Target Milestone: --- → mozilla0.9.8
|
|
Assignee | |
Comment 2•24 years ago
|
||
somewhat complicated logic in SetUploadStream, but this should do the trick.
|
|
Assignee | |
Comment 3•24 years ago
|
||
- improved comment in nsHttpTransaction::SetupRequest
- added extra brace around first if (contentType < 0)
- substituted AppendInt for PR_snprintf
Attachment #64419 -
Attachment is obsolete: true
|
||
Comment 4•24 years ago
|
||
Comment on attachment 64552 [details] [diff] [review]
v1.1 patch - revised per comments from dougt
looks good.
Attachment #64552 -
Flags: review+
|
||
Comment 5•24 years ago
|
||
Comment on attachment 64552 [details] [diff] [review]
v1.1 patch - revised per comments from dougt
sr=alecf
Attachment #64552 -
Flags: superreview+
|
|
Assignee | |
Comment 6•24 years ago
|
||
fixed-on-trunk
|
|
Assignee | |
Comment 7•24 years ago
|
||
fixed-on-trunk (and i really mean it!)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
this seems to have caused bug 119625
|
||
Comment 9•24 years ago
|
||
In nsHttpChannel::SetUploadStream, it seems that the line
mUploadStream = stream;
should be at the beginning at the function, not at the end.
The old code was first initialising mUploadStream, and bug #119625 doesn't seem
to occur with that line moved.
I don't understand this code at all, so I'm sorry if I'm telling stupid things :)
You need to log in
before you can comment on or make changes to this bug.
Description
•