1124839 - base: Entity support custom context

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

It would be nice if we would inject some configuration constants when we call
Entity.setup()

These could just extend the prototype...

Additionally, it would be nice, if doing Entity.configure() we specified which configuration properties had to be injected..

Use:
var TaskGraph = base.Entity.configure({
  ...
  context:   ['schedulerId']  // Configurable constant
})

TaskGraph.prototype.status = function() {
  return {
     ...
     schedulerId:  this.schedulerId
  };
};

in bin/server.js

var data = require(...
var TaskGraph = data.TaskGraph.setup({
   ,,,
   context: {
     schedulerId:      cfg.get('scheduler:schedulerId') // Loaded from configuration
   }
});


This blocks bug 1088920, because we need to port to new entities first...

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: Github PR

See description for what this does :)

I added lots of tests, so there is a reasonable chance this works...

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 8553290 [details] [review]
Github PR

Looks good to me and seems like a good feature to have

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Merged will be published with the next version of taskcluster-base

Comment 4

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...