Closed
Bug 1124858
Opened 10 years ago
Closed 10 years ago
Show WARP status in about:support
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: milan, Assigned: milan)
Details
Attachments
(1 file, 2 obsolete files)
2.27 KB,
patch
|
milan
:
review+
|
Details | Diff | Splinter Review |
Expose whether we're running WARP or not in about:support.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8553316 -
Flags: review?(bas)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → milan
Comment 2•10 years ago
|
||
Comment on attachment 8553316 [details] [diff] [review]
Distinguish between warp and "regular" D3D11
Review of attachment 8553316 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/client/ClientLayerManager.cpp
@@ -28,5 @@
> #include "nsXULAppAPI.h" // for XRE_GetProcessType, etc
> #include "TiledLayerBuffer.h"
> #include "mozilla/dom/WindowBinding.h" // for Overfill Callback
> #include "FrameLayerBuilder.h" // for FrameLayerbuilder
> -#include "gfxPrefs.h"
Can you just remove this? If we can that seems fine.
@@ +739,5 @@
> case LayersBackend::LAYERS_D3D9: aName.AssignLiteral("Direct3D 9"); return;
> case LayersBackend::LAYERS_D3D10: aName.AssignLiteral("Direct3D 10"); return;
> + case LayersBackend::LAYERS_D3D11: {
> +#ifdef XP_WIN
> + if (gfxWindowsPlatform::IsWarp()) {
At least in theory that shouldn't compile... you'd need gfxWindowsPlatform::GetPlatform()->IsWARP()
Attachment #8553316 -
Flags: review?(bas) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #2)
> Comment on attachment 8553316 [details] [diff] [review]
> Distinguish between warp and "regular" D3D11
>
> Review of attachment 8553316 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: gfx/layers/client/ClientLayerManager.cpp
> @@ -28,5 @@
> > #include "nsXULAppAPI.h" // for XRE_GetProcessType, etc
> > #include "TiledLayerBuffer.h"
> > #include "mozilla/dom/WindowBinding.h" // for Overfill Callback
> > #include "FrameLayerBuilder.h" // for FrameLayerbuilder
> > -#include "gfxPrefs.h"
>
> Can you just remove this? If we can that seems fine.
There is another include of the same file up higher in the list...
>
> @@ +739,5 @@
> > case LayersBackend::LAYERS_D3D9: aName.AssignLiteral("Direct3D 9"); return;
> > case LayersBackend::LAYERS_D3D10: aName.AssignLiteral("Direct3D 10"); return;
> > + case LayersBackend::LAYERS_D3D11: {
> > +#ifdef XP_WIN
> > + if (gfxWindowsPlatform::IsWarp()) {
>
> At least in theory that shouldn't compile... you'd need
> gfxWindowsPlatform::GetPlatform()->IsWARP()
Thanks!
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8553316 -
Attachment is obsolete: true
Attachment #8554836 -
Flags: review+
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8554836 -
Attachment is obsolete: true
Attachment #8555470 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•