1124858 - Show WARP status in about:support

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Expose whether we're running WARP or not in about:support.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Distinguish between warp and "regular" D3D11

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8553316 [details] [diff] [review]
Distinguish between warp and "regular" D3D11

Review of attachment 8553316 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/ClientLayerManager.cpp
@@ -28,5 @@
>  #include "nsXULAppAPI.h"                // for XRE_GetProcessType, etc
>  #include "TiledLayerBuffer.h"
>  #include "mozilla/dom/WindowBinding.h"  // for Overfill Callback
>  #include "FrameLayerBuilder.h"          // for FrameLayerbuilder
> -#include "gfxPrefs.h"

Can you just remove this? If we can that seems fine.

@@ +739,5 @@
>      case LayersBackend::LAYERS_D3D9: aName.AssignLiteral("Direct3D 9"); return;
>      case LayersBackend::LAYERS_D3D10: aName.AssignLiteral("Direct3D 10"); return;
> +    case LayersBackend::LAYERS_D3D11: {
> +#ifdef XP_WIN
> +      if (gfxWindowsPlatform::IsWarp()) {

At least in theory that shouldn't compile... you'd need gfxWindowsPlatform::GetPlatform()->IsWARP()

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Bas Schouten (:bas.schouten) from comment #2)
> Comment on attachment 8553316 [details] [diff] [review]
> Distinguish between warp and "regular" D3D11
> 
> Review of attachment 8553316 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/client/ClientLayerManager.cpp
> @@ -28,5 @@
> >  #include "nsXULAppAPI.h"                // for XRE_GetProcessType, etc
> >  #include "TiledLayerBuffer.h"
> >  #include "mozilla/dom/WindowBinding.h"  // for Overfill Callback
> >  #include "FrameLayerBuilder.h"          // for FrameLayerbuilder
> > -#include "gfxPrefs.h"
> 
> Can you just remove this? If we can that seems fine.

There is another include of the same file up higher in the list...

> 
> @@ +739,5 @@
> >      case LayersBackend::LAYERS_D3D9: aName.AssignLiteral("Direct3D 9"); return;
> >      case LayersBackend::LAYERS_D3D10: aName.AssignLiteral("Direct3D 10"); return;
> > +    case LayersBackend::LAYERS_D3D11: {
> > +#ifdef XP_WIN
> > +      if (gfxWindowsPlatform::IsWarp()) {
> 
> At least in theory that shouldn't compile... you'd need
> gfxWindowsPlatform::GetPlatform()->IsWARP()

Thanks!

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Distinguish between warp and "regular" D3D11. Carry r=bschouten

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0ef06de9c89

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Distinguish between warp and "regular" D3D11. Carry r=bschouten

Sigh.  https://hg.mozilla.org/try/rev/9b64d31433a5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f327677b913

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f327677b913