Closed Bug 1124862 Opened 9 years ago Closed 8 years ago

toolkit/xre/glxtest.cpp fails to compile again on linux gcc 4.7 with -Wunused-variable warnings

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

Fix glxtest.cpp fail-on-warning errors for ignored return values. (v0)
2.38 KB, patch
bjacob
: review+
Details | Diff | Splinter Review 
9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp: In function ‘void glxtest()’:
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp:252:44: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp: In function ‘void fatal_error(const char*)’:
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp:84:49: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp:85:40: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp: In function ‘int x_error_handler(Display*, XErrorEvent*)’:
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp:99:44: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
 9:31.45 cc1plus: all warnings being treated as errors
Assignee: nobody → bkelly
Status: NEW → ASSIGNED

        Attachment #8553323 -
        Flags: review?(jacob.benoit.1)

    
    

    
  
FWIW: I also hit this with clang 3.6 on linux, when compiling an opt build.

        Attachment #8553323 -
        Flags: review?(jacob.benoit.1) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/cd52e9f67e75
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38

          You need to log in
          before you can comment on or make changes to this bug.