1124862 - toolkit/xre/glxtest.cpp fails to compile again on linux gcc 4.7 with -Wunused-variable warnings

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp: In function ‘void glxtest()’:
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp:252:44: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp: In function ‘void fatal_error(const char*)’:
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp:84:49: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp:85:40: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp: In function ‘int x_error_handler(Display*, XErrorEvent*)’:
 9:31.45 /srv/mozilla-central/toolkit/xre/glxtest.cpp:99:44: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
 9:31.45 cc1plus: all warnings being treated as errors

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Fix glxtest.cpp fail-on-warning errors for ignored return values. (v0)

Comment 2

[Daniel Holbert [:dholbert]]

FWIW: I also hit this with clang 3.6 on linux, when compiling an opt build.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd52e9f67e75

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd52e9f67e75